2009-12-02 14:29:35

by Holger Schurig

[permalink] [raw]
Subject: [PATCH 00/10] [PATCH] libertas: remove WEXT, add CFG80211

This is my current incarnation of the patch, after I managed today
to get IBSS and MONITOR working.

Especially the last patch is a "gem": 1984 lines added, but 6691 lines
deleted :-)

--


2009-12-02 20:45:45

by Dan Williams

[permalink] [raw]
Subject: Re: [PATCH 00/10] [PATCH] libertas: remove WEXT, add CFG80211

On Wed, 2009-12-02 at 15:25 +0100, Holger Schurig wrote:
> This is my current incarnation of the patch, after I managed today
> to get IBSS and MONITOR working.
>
> Especially the last patch is a "gem": 1984 lines added, but 6691 lines
> deleted :-)

Hell yeah :)

Dan


2009-12-03 10:03:09

by Holger Schurig

[permalink] [raw]
Subject: Re: [PATCH 00/10] [PATCH] libertas: remove WEXT, add CFG80211

Can you please have a look at the "#ifdef TODO" in cmd.c?

On libertas+cfg80211, there's no priv->secinfo. And there's no
way "to check for valid WPA/WPA2 group keys", at least not that
I know off. Also I don't know what this code section does and
how to do it better.

Maybe it tries to prevent sleeping between two consecute "set
type X key" calls, but maybe we'd better use a
priv->dont_sleep_now" flag for that, that we set and clear in
lbs_cfg_add_key ?!?

--
http://www.holgerschurig.de