2010-03-29 23:12:56

by Luis de Bethencourt

Subject: [PATCH 2/2] ath: fix macros coding style issue in regd.c

This is a patch to the ath/regd.c file that fixes up three warnings
about macros found by the checkpatch.pl tool, these said that
complex values should be enclosed in parenthesis.

Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/net/wireless/ath/regd.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/regd.c b/drivers/net/wireless/ath/regd.c
index 04abd1f..971edc4 100644
--- a/drivers/net/wireless/ath/regd.c
+++ b/drivers/net/wireless/ath/regd.c
@@ -45,15 +45,16 @@
#define ATH9K_5GHZ_5725_5850 REG_RULE(5725-10, 5850+10, 40, 0, 30,\
NL80211_RRF_PASSIVE_SCAN | NL80211_RRF_NO_IBSS)

-#define ATH9K_2GHZ_ALL ATH9K_2GHZ_CH01_11, \
+#define ATH9K_2GHZ_ALL (ATH9K_2GHZ_CH01_11, \
ATH9K_2GHZ_CH12_13, \
- ATH9K_2GHZ_CH14
+ ATH9K_2GHZ_CH14)
+
+#define ATH9K_5GHZ_ALL (ATH9K_5GHZ_5150_5350, \
+ ATH9K_5GHZ_5470_5850)

-#define ATH9K_5GHZ_ALL ATH9K_5GHZ_5150_5350, \
- ATH9K_5GHZ_5470_5850
/* This one skips what we call "mid band" */
-#define ATH9K_5GHZ_NO_MIDBAND ATH9K_5GHZ_5150_5350, \
- ATH9K_5GHZ_5725_5850
+#define ATH9K_5GHZ_NO_MIDBAND (ATH9K_5GHZ_5150_5350, \
+ ATH9K_5GHZ_5725_5850)

/* Can be used for:
* 0x60, 0x61, 0x62 */
--
1.6.3.3

2010-03-29 23:33:46

by Joe Perches

Subject: Re: [PATCH 2/2] ath: fix macros coding style issue in regd.c

On Tue, 2010-03-30 at 00:12 +0100, Luis de Bethencourt wrote:
> This is a patch to the ath/regd.c file that fixes up three warnings
> about macros found by the checkpatch.pl tool, these said that
> complex values should be enclosed in parenthesis.

Hi Luis.

Checkpatch isn't always correct.

Please make sure to compile test your changes
before submitting them.

These macros are used as initializers and
can not be surrounded by parentheses.

.reg_rules = {
ATH9K_2GHZ_ALL,

cheers, Joe

2010-03-29 23:39:21

by Luis de Bethencourt

Subject: Re: [PATCH 2/2] ath: fix macros coding style issue in regd.c

On Tue, Mar 30, 2010 at 12:33 AM, Joe Perches <[email protected]> wrote:
> On Tue, 2010-03-30 at 00:12 +0100, Luis de Bethencourt wrote:
>> This is a patch to the ath/regd.c file that fixes up three warnings
>> about macros found by the checkpatch.pl tool, these said that
>> complex values should be enclosed in parenthesis.
>
> Hi Luis.
>
> Checkpatch isn't always correct.
>
> Please make sure to compile test your changes
> before submitting them.
>
> These macros are used as initializers and
> can not be surrounded by parentheses.
>
> ? ? ? ?.reg_rules = {
> ? ? ? ? ? ? ? ?ATH9K_2GHZ_ALL,
>
> cheers, Joe
>
>

Hi Joe,

Sorry about this. I compiled test the changes but make didn't complain.

My bad, will try to avoid this better in the future.

Luis