2010-04-16 13:49:28

by Stanislaw Gruszka

Subject: [PATCH] iwlwifi: initialize iwl_wimax_coex_cmd.flags

iwl_wimax_coex_cmd.flags can be really uninitialized, so fix
that.

Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/iwlwifi/iwl-core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
index f09bff8..2e489cd 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -2382,11 +2382,11 @@ EXPORT_SYMBOL(iwl_free_txq_mem);

int iwl_send_wimax_coex(struct iwl_priv *priv)
{
- struct iwl_wimax_coex_cmd uninitialized_var(coex_cmd);
+ struct iwl_wimax_coex_cmd coex_cmd;

if (priv->cfg->support_wimax_coexist) {
/* UnMask wake up src at associated sleep */
- coex_cmd.flags |= COEX_FLAGS_ASSOC_WA_UNMASK_MSK;
+ coex_cmd.flags = COEX_FLAGS_ASSOC_WA_UNMASK_MSK;

/* UnMask wake up src at unassociated sleep */
coex_cmd.flags |= COEX_FLAGS_UNASSOC_WA_UNMASK_MSK;
--
1.6.2.5

2010-04-16 18:04:51

by Reinette Chatre

Subject: Re: [PATCH] iwlwifi: initialize iwl_wimax_coex_cmd.flags

On Fri, 2010-04-16 at 06:47 -0700, Stanislaw Gruszka wrote:
> iwl_wimax_coex_cmd.flags can be really uninitialized, so fix
> that.
>
> Signed-off-by: Stanislaw Gruszka <[email protected]>
> ---

Thank you

Acked-by: Reinette Chatre <[email protected]>

Reinette