2010-09-04 22:55:43

by Michael Büsch

Subject: [PATCH] p54spi: Add error message for eeprom failure

This adds an error message for the eeprom request failure
case. This way it's easier for the user to figure out
what went wrong.

Signed-off-by: Michael Büsch <[email protected]>

---
drivers/net/wireless/p54/p54spi.c | 2 ++
1 file changed, 2 insertions(+)

--- wireless-testing.orig/drivers/net/wireless/p54/p54spi.c
+++ wireless-testing/drivers/net/wireless/p54/p54spi.c
@@ -202,6 +202,8 @@ static int p54spi_request_eeprom(struct
dev_info(&priv->spi->dev, "loading default eeprom...\n");
ret = p54_parse_eeprom(dev, (void *) p54spi_eeprom,
sizeof(p54spi_eeprom));
+#else
+ dev_err(&priv->spi->dev, "Failed to request user eeprom\n");
#endif /* CONFIG_P54_SPI_DEFAULT_EEPROM */
} else {
dev_info(&priv->spi->dev, "loading user eeprom...\n");

2010-09-04 23:37:54

by Christian Lamparter

Subject: Re: [PATCH] p54spi: Add error message for eeprom failure

On Sunday 05 September 2010 00:55:38 Michael Büsch wrote:
> This adds an error message for the eeprom request failure
> case. This way it's easier for the user to figure out
> what went wrong.
>
> Signed-off-by: Michael Büsch <[email protected]>
Acked-by: Christian Lamparter <[email protected]>