2010-09-30 11:50:34

by Tuomas Katila

[permalink] [raw]
Subject: Re: [PATCH 2/2] wl1271: Move work-init calls to hw allocation


On Thu, 2010-09-30 at 13:37 +0200, Juuso Oikarinen wrote:
> From: Juuso Oikarinen <[email protected]>
>
> Due to legacy reason, dating back to when the wl1251 and wl1271 still were
> a unified driver, some work-structures are initialized on hardware startup.
>
> The hardware recovery code creates a scenario in which it is possible for a
> workstruct to be re-initialized while the work-function itself is running,
> which causes a kernel WARNing and a subsequent reboot.
>
> To remedy this, move the work initialization calls to the hw allocation,
> which is the logically correct place for them anyway.
>
> Signed-off-by: Juuso Oikarinen <[email protected]>
> ---

Tested-by: Tuomas Katila <[email protected]>

-Tuomas