2010-10-05 12:26:22

by Kahn, Gery

[permalink] [raw]
Subject: [PATCH] ref_clock cosmetic changes

Signed-off-by: Gery Kahn <[email protected]>
---
drivers/net/wireless/wl12xx/wl1271_boot.c | 10 ++++------
include/linux/wl12xx.h | 8 ++++++++
2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/wl1271_boot.c b/drivers/net/wireless/wl12xx/wl1271_boot.c
index b910212..5b19072 100644
--- a/drivers/net/wireless/wl12xx/wl1271_boot.c
+++ b/drivers/net/wireless/wl12xx/wl1271_boot.c
@@ -471,20 +471,19 @@ int wl1271_boot(struct wl1271 *wl)
{
int ret = 0;
u32 tmp, clk, pause;
- int ref_clock = wl->ref_clock;

wl1271_boot_hw_version(wl);

- if (ref_clock == 0 || ref_clock == 2 || ref_clock == 4)
+ if (wl->ref_clock == 0 || wl->ref_clock == 2 || wl->ref_clock == 4)
/* ref clk: 19.2/38.4/38.4-XTAL */
clk = 0x3;
- else if (ref_clock == 1 || ref_clock == 3)
+ else if (wl->ref_clock == 1 || wl->ref_clock == 3)
/* ref clk: 26/52 */
clk = 0x5;
else
return -EINVAL;

- if (ref_clock != 0) {
+ if (wl->ref_clock != 0) {
u16 val;
/* Set clock type (open drain) */
val = wl1271_top_reg_read(wl, OCP_REG_CLK_TYPE);
@@ -529,8 +528,7 @@ int wl1271_boot(struct wl1271 *wl)

wl1271_debug(DEBUG_BOOT, "clk2 0x%x", clk);

- /* 2 */
- clk |= (ref_clock << 1) << 4;
+ clk |= (wl->ref_clock << 1) << 4;
wl1271_write32(wl, DRPW_SCRATCH_START, clk);

wl1271_set_partition(wl, &part_table[PART_WORK]);
diff --git a/include/linux/wl12xx.h b/include/linux/wl12xx.h
index 4f902e1..3092980 100644
--- a/include/linux/wl12xx.h
+++ b/include/linux/wl12xx.h
@@ -24,6 +24,14 @@
#ifndef _LINUX_WL12XX_H
#define _LINUX_WL12XX_H

+/*
+ * The board reference clock values:
+ * 0 = 19.2 MHz
+ * 1 = 26 MHz
+ * 2 = 38.4 MHz
+ * 3 = 54 MHz
+ */
+
struct wl12xx_platform_data {
void (*set_power)(bool enable);
/* SDIO only: IRQ number if WLAN_IRQ line is used, 0 for SDIO IRQs */
--
1.7.0.4



2010-10-05 13:45:06

by John W. Linville

[permalink] [raw]
Subject: Re: [PATCH] ref_clock cosmetic changes

On Tue, Oct 05, 2010 at 02:26:19PM +0200, Gery Kahn wrote:
> Signed-off-by: Gery Kahn <[email protected]>

Please prefix your patch subjects with something to indicate the
driver or subsystem you are patching. In this case, something like
"wl1271: ref_clock cosmetic changes".

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.