2010-11-03 20:36:55

by Rafał Miłecki

Subject: [PATCH] b43legacy: rfkill: use status register based on core revision (not PHY's)

Signed-off-by: Rafał Miłecki <[email protected]>
---
With this patch we follow specs. I hope this will fix bug where radio was
magically auto-turning on/off. Unfortunately I didn't get answer from reporter
of that issue.

John: I suggest taking it for 2.6.38
---
drivers/net/wireless/b43legacy/rfkill.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/b43legacy/rfkill.c b/drivers/net/wireless/b43legacy/rfkill.c
index d579df7..b90f223 100644
--- a/drivers/net/wireless/b43legacy/rfkill.c
+++ b/drivers/net/wireless/b43legacy/rfkill.c
@@ -29,7 +29,7 @@
/* Returns TRUE, if the radio is enabled in hardware. */
bool b43legacy_is_hw_radio_enabled(struct b43legacy_wldev *dev)
{
- if (dev->phy.rev >= 3) {
+ if (dev->dev->id.revision >= 3) {
if (!(b43legacy_read32(dev, B43legacy_MMIO_RADIO_HWENABLED_HI)
& B43legacy_MMIO_RADIO_HWENABLED_HI_MASK))
return 1;
--
1.6.0.4

2010-11-03 20:49:57

by Larry Finger

Subject: Re: [PATCH] b43legacy: rfkill: use status register based on core revision (not PHY's)

On 11/03/2010 03:36 PM, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <[email protected]>
> ---
> With this patch we follow specs. I hope this will fix bug where radio was
> magically auto-turning on/off. Unfortunately I didn't get answer from reporter
> of that issue.
>
> John: I suggest taking it for 2.6.38

ACK, both for the patch and the suggestion for the timing.

Larry