LinuxLists.cc - [stable 2.6.37][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

2011-02-28 06:20:59

Subject: [stable 2.6.37][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

2011-02-28 14:23:51

Subject: Re: [stable] [stable 2.6.37][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

On Mon, Feb 28, 2011 at 11:50:53AM +0530, Vivek Natarajan wrote:
> The default qos value of 55 causes higher power consumption
> and the battery drains out quickly. So, remove the pm_qos request
> in the driver and the throughout issue in the Intel Pinetrail
> platforms in which the DMA latency is seen can be fixed with
> the following script:
> http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/cpudmalatency.c
> http://johannes.sipsolutions.net/files/netlatency.c.txt
>
> More details can be found in the following bugzilla link:
> https://bugzilla.kernel.org/show_bug.cgi?id=27532
>
> Cc: [email protected]
> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
> Signed-off-by: Vivek Natarajan <[email protected]>

Why did you send me 3 copies of this patch, when I don't need any copies
of it?

Totally confused,

greg k-h

2011-02-28 17:35:05

by Greg KH

[permalink] [raw]

Subject: Re: [stable] [stable 2.6.37][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

On Mon, Feb 28, 2011 at 09:21:01AM -0800, Luis R. Rodriguez wrote:
> On Mon, Feb 28, 2011 at 9:20 AM, Luis R. Rodriguez <[email protected]> wrote:
> > On Mon, Feb 28, 2011 at 8:52 AM, Vivek Natarajan <[email protected]> wrote:
> >> On Mon, Feb 28, 2011 at 8:18 PM, Luis R. Rodriguez <[email protected]> wrote:
> >>> On Mon, Feb 28, 2011 at 6:22 AM, Greg KH <[email protected]> wrote:
> >>>> On Mon, Feb 28, 2011 at 11:50:53AM +0530, Vivek Natarajan wrote:
> >>>>> The default qos value of 55 causes higher power consumption
> >>>>> and the battery drains out quickly. So, remove the pm_qos request
> >>>>> in the driver and the throughout issue in the Intel Pinetrail
> >>>>> platforms in which the DMA latency is seen can be fixed with
> >>>>> the following script:
> >>>>> http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/cpudmalatency.c
> >>>>> http://johannes.sipsolutions.net/files/netlatency.c.txt
> >>>>>
> >>>>> More details can be found in the following bugzilla link:
> >>>>> https://bugzilla.kernel.org/show_bug.cgi?id=27532
> >>>>>
> >>>>> Cc: [email protected]
> >>>>> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
> >>>>> Signed-off-by: Vivek Natarajan <[email protected]>
> >>>>
> >>>> Why did you send me 3 copies of this patch, when I don't need any copies
> >>>> of it?
> >>>>
> >>>> Totally confused,
> >>>
> >>> Vivek, please only ask John to send this to David as stable so it can
> >>> get into 2.6.38-rc, then once there you can refer the sha1sum from
> >>> Linus' tree and justify propagating into the stable series.
> >>>
> >> I had sent separate patches for v2.6.37 and for v2.6.38 since the
> >> patch could not be applied directly to previous versions. So, should I
> >> send this rebased patch for v2.6.37 only after it makes it into
> >> v2.6.38?
> >
> > Affirmative. You cannot propagate stable patches unless they are
> > already in Linus' tree.
>
> See:
>
> http://wireless.kernel.org/en/users/Documentation/Fix_Propagation

And of course, the file, Documentation/stable_kernel_rules.txt

thanks,

greg k-h

2011-02-28 06:21:05

by Vivek Natarajan

[permalink] [raw]

Subject: [stable 2.6.38][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

The default qos value of 55 causes higher power consumption
and the battery drains out quickly. So, remove the pm_qos request
in the driver and the throughout issue in the Intel Pinetrail
platforms in which the DMA latency is seen can be fixed with
the following script:
http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/cpudmalatency.c
http://johannes.sipsolutions.net/files/netlatency.c.txt

More details can be found in the following bugzilla link:
https://bugzilla.kernel.org/show_bug.cgi?id=27532

Cc: [email protected]
Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
Signed-off-by: Vivek Natarajan <[email protected]>
---
drivers/net/wireless/ath/ath9k/ath9k.h | 5 -----
drivers/net/wireless/ath/ath9k/init.c | 7 -------
drivers/net/wireless/ath/ath9k/main.c | 8 --------
3 files changed, 0 insertions(+), 20 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index 23838e3..a993d8a 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -21,7 +21,6 @@
#include <linux/device.h>
#include <linux/leds.h>
#include <linux/completion.h>
-#include <linux/pm_qos_params.h>

#include "debug.h"
#include "common.h"
@@ -57,8 +56,6 @@ struct ath_node;

#define A_MAX(a, b) ((a) > (b) ? (a) : (b))

-#define ATH9K_PM_QOS_DEFAULT_VALUE 55
-
#define TSF_TO_TU(_h,_l) \
((((u32)(_h)) << 22) | (((u32)(_l)) >> 10))

@@ -634,7 +631,6 @@ struct ath_softc {

struct ath_ant_comb ant_comb;

- struct pm_qos_request_list pm_qos_req;
};

struct ath_wiphy {
@@ -666,7 +662,6 @@ static inline void ath_read_cachesize(struct ath_common *common, int *csz)
extern struct ieee80211_ops ath9k_ops;
extern int ath9k_modparam_nohwcrypt;
extern int led_blink;
-extern int ath9k_pm_qos_value;
extern bool is_ath9k_unloaded;

irqreturn_t ath_isr(int irq, void *dev);
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 087a6a9..82cac80 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -41,9 +41,6 @@ static int ath9k_btcoex_enable;
module_param_named(btcoex_enable, ath9k_btcoex_enable, int, 0444);
MODULE_PARM_DESC(btcoex_enable, "Enable wifi-BT coexistence");

-int ath9k_pm_qos_value = ATH9K_PM_QOS_DEFAULT_VALUE;
-module_param_named(pmqos, ath9k_pm_qos_value, int, S_IRUSR | S_IRGRP | S_IROTH);
-MODULE_PARM_DESC(pmqos, "User specified PM-QOS value");

bool is_ath9k_unloaded;
/* We use the hw_value as an index into our private channel structure */
@@ -762,9 +759,6 @@ int ath9k_init_device(u16 devid, struct ath_softc *sc, u16 subsysid,
ath_init_leds(sc);
ath_start_rfkill_poll(sc);

- pm_qos_add_request(&sc->pm_qos_req, PM_QOS_CPU_DMA_LATENCY,
- PM_QOS_DEFAULT_VALUE);
-
return 0;

error_world:
@@ -831,7 +825,6 @@ void ath9k_deinit_device(struct ath_softc *sc)
}

ieee80211_unregister_hw(hw);
- pm_qos_remove_request(&sc->pm_qos_req);
ath_rx_cleanup(sc);
ath_tx_cleanup(sc);
ath9k_deinit_softc(sc);
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index da5c645..a09d15f 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1173,12 +1173,6 @@ static int ath9k_start(struct ieee80211_hw *hw)
ath9k_btcoex_timer_resume(sc);
}

- /* User has the option to provide pm-qos value as a module
- * parameter rather than using the default value of
- * 'ATH9K_PM_QOS_DEFAULT_VALUE'.
- */
- pm_qos_update_request(&sc->pm_qos_req, ath9k_pm_qos_value);
-
if (ah->caps.pcie_lcr_extsync_en && common->bus_ops->extn_synch_en)
common->bus_ops->extn_synch_en(common);

@@ -1345,8 +1339,6 @@ static void ath9k_stop(struct ieee80211_hw *hw)

sc->sc_flags |= SC_OP_INVALID;

- pm_qos_update_request(&sc->pm_qos_req, PM_QOS_DEFAULT_VALUE);
-
mutex_unlock(&sc->mutex);

ath_dbg(common, ATH_DBG_CONFIG, "Driver halt\n");
--
1.7.3.4

2011-02-28 16:52:04

by Vivek Natarajan

[permalink] [raw]

Subject: Re: [stable] [stable 2.6.37][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

On Mon, Feb 28, 2011 at 8:18 PM, Luis R. Rodriguez <[email protected]> wrote:
> On Mon, Feb 28, 2011 at 6:22 AM, Greg KH <[email protected]> wrote:
>> On Mon, Feb 28, 2011 at 11:50:53AM +0530, Vivek Natarajan wrote:
>>> The default qos value of 55 causes higher power consumption
>>> and the battery drains out quickly. So, remove the pm_qos request
>>> in the driver and the throughout issue in the Intel Pinetrail
>>> platforms in which the DMA latency is seen can be fixed with
>>> the following script:
>>> http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/cpudmalatency.c
>>> http://johannes.sipsolutions.net/files/netlatency.c.txt
>>>
>>> More details can be found in the following bugzilla link:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=27532
>>>
>>> Cc: [email protected]
>>> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
>>> Signed-off-by: Vivek Natarajan <[email protected]>
>>
>> Why did you send me 3 copies of this patch, when I don't need any copies
>> of it?
>>
>> Totally confused,
>
> Vivek, please only ask John to send this to David as stable so it can
> get into 2.6.38-rc, then once there you can refer the sha1sum from
> Linus' tree and justify propagating into the stable series.
>
I had sent separate patches for v2.6.37 and for v2.6.38 since the
patch could not be applied directly to previous versions. So, should I
send this rebased patch for v2.6.37 only after it makes it into
v2.6.38?

Vivek.

2011-02-28 17:21:21

by Luis R. Rodriguez

[permalink] [raw]

Subject: Re: [stable] [stable 2.6.37][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

On Mon, Feb 28, 2011 at 9:20 AM, Luis R. Rodriguez <[email protected]> wrote:
> On Mon, Feb 28, 2011 at 8:52 AM, Vivek Natarajan <[email protected]> wrote:
>> On Mon, Feb 28, 2011 at 8:18 PM, Luis R. Rodriguez <[email protected]> wrote:
>>> On Mon, Feb 28, 2011 at 6:22 AM, Greg KH <[email protected]> wrote:
>>>> On Mon, Feb 28, 2011 at 11:50:53AM +0530, Vivek Natarajan wrote:
>>>>> The default qos value of 55 causes higher power consumption
>>>>> and the battery drains out quickly. So, remove the pm_qos request
>>>>> in the driver and the throughout issue in the Intel Pinetrail
>>>>> platforms in which the DMA latency is seen can be fixed with
>>>>> the following script:
>>>>> http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/cpudmalatency.c
>>>>> http://johannes.sipsolutions.net/files/netlatency.c.txt
>>>>>
>>>>> More details can be found in the following bugzilla link:
>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=27532
>>>>>
>>>>> Cc: [email protected]
>>>>> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
>>>>> Signed-off-by: Vivek Natarajan <[email protected]>
>>>>
>>>> Why did you send me 3 copies of this patch, when I don't need any copies
>>>> of it?
>>>>
>>>> Totally confused,
>>>
>>> Vivek, please only ask John to send this to David as stable so it can
>>> get into 2.6.38-rc, then once there you can refer the sha1sum from
>>> Linus' tree and justify propagating into the stable series.
>>>
>> I had sent separate patches for v2.6.37 and for v2.6.38 since the
>> patch could not be applied directly to previous versions. So, should I
>> send this rebased patch for v2.6.37 only after it makes it into
>> v2.6.38?
>
> Affirmative. You cannot propagate stable patches unless they are
> already in Linus' tree.

See:

http://wireless.kernel.org/en/users/Documentation/Fix_Propagation

Luis

2011-02-28 17:20:43

by Luis R. Rodriguez

[permalink] [raw]

Subject: Re: [stable] [stable 2.6.37][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

On Mon, Feb 28, 2011 at 8:52 AM, Vivek Natarajan <[email protected]> wrote:
> On Mon, Feb 28, 2011 at 8:18 PM, Luis R. Rodriguez <[email protected]> wrote:
>> On Mon, Feb 28, 2011 at 6:22 AM, Greg KH <[email protected]> wrote:
>>> On Mon, Feb 28, 2011 at 11:50:53AM +0530, Vivek Natarajan wrote:
>>>> The default qos value of 55 causes higher power consumption
>>>> and the battery drains out quickly. So, remove the pm_qos request
>>>> in the driver and the throughout issue in the Intel Pinetrail
>>>> platforms in which the DMA latency is seen can be fixed with
>>>> the following script:
>>>> http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/cpudmalatency.c
>>>> http://johannes.sipsolutions.net/files/netlatency.c.txt
>>>>
>>>> More details can be found in the following bugzilla link:
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=27532
>>>>
>>>> Cc: [email protected]
>>>> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
>>>> Signed-off-by: Vivek Natarajan <[email protected]>
>>>
>>> Why did you send me 3 copies of this patch, when I don't need any copies
>>> of it?
>>>
>>> Totally confused,
>>
>> Vivek, please only ask John to send this to David as stable so it can
>> get into 2.6.38-rc, then once there you can refer the sha1sum from
>> Linus' tree and justify propagating into the stable series.
>>
> I had sent separate patches for v2.6.37 and for v2.6.38 since the
> patch could not be applied directly to previous versions. So, should I
> send this rebased patch for v2.6.37 only after it makes it into
> v2.6.38?

Affirmative. You cannot propagate stable patches unless they are
already in Linus' tree.

Luis

2011-02-28 14:49:16

by Luis R. Rodriguez

[permalink] [raw]

Subject: Re: [stable] [stable 2.6.37][PATCH] ath9k: Fix ath9k to allow CPU to enter C3 state.

On Mon, Feb 28, 2011 at 6:22 AM, Greg KH <[email protected]> wrote:
> On Mon, Feb 28, 2011 at 11:50:53AM +0530, Vivek Natarajan wrote:
>> The default qos value of 55 causes higher power consumption
>> and the battery drains out quickly. So, remove the pm_qos request
>> in the driver and the throughout issue in the Intel Pinetrail
>> platforms in which the DMA latency is seen can be fixed with
>> the following script:
>> http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/cpudmalatency.c
>> http://johannes.sipsolutions.net/files/netlatency.c.txt
>>
>> More details can be found in the following bugzilla link:
>> https://bugzilla.kernel.org/show_bug.cgi?id=27532
>>
>> Cc: [email protected]
>> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
>> Signed-off-by: Vivek Natarajan <[email protected]>
>
> Why did you send me 3 copies of this patch, when I don't need any copies
> of it?
>
> Totally confused,

Vivek, please only ask John to send this to David as stable so it can
get into 2.6.38-rc, then once there you can refer the sha1sum from
Linus' tree and justify propagating into the stable series.

Luis