Hi Daniel,
On Fri, 2011-03-04 at 16:15 -0800, Daniel Halperin wrote:
> drivers/net/wireless/iwlwifi/iwl-rx.c: In function
> ‘iwl_rx_card_state_notif’:
> drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: ‘TASK_INTERRUPTIBLE’
> undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: (Each undeclared
> identifier is reported only once
> drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: for each function it
> appears in.)
>
>
> iwl-tx.c has an include for sched.h that isn't here and is probably
> the problem.
>
>
Stanislow last patch
commit 466a19a003f3b45a755bc85f967c21da947f9a00: iwlwifi: move rx
handlers code to iwl-rx.c
break the compile
John, please revert the patch
Thanks
Wey
Hi John,
On Sun, 2011-03-06 at 17:27 -0800, John W. Linville wrote:
> On Sun, Mar 06, 2011 at 01:26:49PM -0800, Guy, Wey-Yi wrote:
> > Hi Daniel,
> >
> >
> > On Fri, 2011-03-04 at 16:15 -0800, Daniel Halperin wrote:
> > > drivers/net/wireless/iwlwifi/iwl-rx.c: In function
> > > ‘iwl_rx_card_state_notif’:
> > > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: ‘TASK_INTERRUPTIBLE’
> > > undeclared (first use in this function)
> > > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: (Each undeclared
> > > identifier is reported only once
> > > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: for each function it
> > > appears in.)
> > >
> > >
> > > iwl-tx.c has an include for sched.h that isn't here and is probably
> > > the problem.
> > >
> > >
> > Stanislow last patch
> > commit 466a19a003f3b45a755bc85f967c21da947f9a00: iwlwifi: move rx
> > handlers code to iwl-rx.c
> > break the compile
> >
> > John, please revert the patch
>
> That seems a bit silly. Does adding an include for sched.h to iwl-rx.c
> fix the build issue?
>
> I wonder why this builds fine for me? What arch fails to build?
yes, adding sched.h works just fine and it is easy to fix, just not sure
should we add a patch and leave the compile broken or revert the patch
then re-submit with one line added. both works for me; just don't like
have the code can not compile at one point. :-)
it is my regular ubuntu 32 bit build system for me and nothing
different, not sure why works for you?
Thanks
Wey
On Sun, Mar 06, 2011 at 01:26:49PM -0800, Guy, Wey-Yi wrote:
> Hi Daniel,
>
>
> On Fri, 2011-03-04 at 16:15 -0800, Daniel Halperin wrote:
> > drivers/net/wireless/iwlwifi/iwl-rx.c: In function
> > ‘iwl_rx_card_state_notif’:
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: ‘TASK_INTERRUPTIBLE’
> > undeclared (first use in this function)
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: (Each undeclared
> > identifier is reported only once
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: for each function it
> > appears in.)
> >
> >
> > iwl-tx.c has an include for sched.h that isn't here and is probably
> > the problem.
> >
> >
> Stanislow last patch
> commit 466a19a003f3b45a755bc85f967c21da947f9a00: iwlwifi: move rx
> handlers code to iwl-rx.c
> break the compile
>
> John, please revert the patch
That seems a bit silly. Does adding an include for sched.h to iwl-rx.c
fix the build issue?
I wonder why this builds fine for me? What arch fails to build?
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Sun, Mar 6, 2011 at 5:27 PM, John W. Linville <[email protected]> wrote:
> That seems a bit silly. ?Does adding an include for sched.h to iwl-rx.c
> fix the build issue?
Yes, the linux/sched.h include succeeds.
> I wonder why this builds fine for me? ?What arch fails to build?
I've got a regular x86 (32-bit) Ubuntu 10.04.1 LTS system running on
wireless-testing master-2011-03-04, and I get this error. I've put my
.config, as well as the error message, up on gist:
https://gist.github.com/857960
Dan