2011-03-28 07:32:30

by Shahar Levi

Subject: [PATCH] wl12xx: Set correct REF CLK and TCXO CLK values to the FW

Set the correct values to the FW of REF CLK and TCXO CLK from
wl12xx_platform_data to ini_general_params.

Signed-off-by: Shahar Levi <[email protected]>
---
drivers/net/wireless/wl12xx/cmd.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/cmd.c b/drivers/net/wireless/wl12xx/cmd.c
index 2468044..beb9f88 100644
--- a/drivers/net/wireless/wl12xx/cmd.c
+++ b/drivers/net/wireless/wl12xx/cmd.c
@@ -129,6 +129,9 @@ int wl1271_cmd_general_parms(struct wl1271 *wl)
if (gp->tx_bip_fem_auto_detect)
answer = true;

+ /* Set the ref CLK value */
+ gen_parms->general_params.ref_clock = wl->ref_clock;
+
ret = wl1271_cmd_test(wl, gen_parms, sizeof(*gen_parms), answer);
if (ret < 0) {
wl1271_warning("CMD_INI_FILE_GENERAL_PARAM failed");
@@ -168,6 +171,13 @@ int wl128x_cmd_general_parms(struct wl1271 *wl)
if (gp->tx_bip_fem_auto_detect)
answer = true;

+ /*
+ * Set the ref CLK & TCXO values.
+ * The HW will know which of them is the valid one due to boot setting.
+ */
+ gen_parms->general_params.ref_clock = wl->ref_clock;
+ gen_parms->general_params.tcxo_ref_clock = wl->tcxo_clock;
+
ret = wl1271_cmd_test(wl, gen_parms, sizeof(*gen_parms), answer);
if (ret < 0) {
wl1271_warning("CMD_INI_FILE_GENERAL_PARAM failed");
--
1.7.0.4

2011-04-03 08:18:46

by Shahar Levi

Subject: Re: [PATCH] wl12xx: Set correct REF CLK and TCXO CLK values to the FW

On Fri, Apr 1, 2011 at 11:48 AM, Luciano Coelho <[email protected]> wrote:
> On Mon, 2011-03-28 at 09:34 +0200, Shahar Levi wrote:
>> Set the correct values to the FW of REF CLK and TCXO CLK from
>> wl12xx_platform_data to ini_general_params.
>>
>> Signed-off-by: Shahar Levi <[email protected]>
>> ---
>
> Please rephrase the commit message. ?Say why we need to do this. ?The
> reason is that we don't want to have a mismatch between the information
> that is set in the platform data and the NVS, so we override what comes
> from the NVS and replace it with what comes from the platform data.
will be fix

>
>
>> diff --git a/drivers/net/wireless/wl12xx/cmd.c b/drivers/net/wireless/wl12xx/cmd.c
>> index 2468044..beb9f88 100644
>> --- a/drivers/net/wireless/wl12xx/cmd.c
>> +++ b/drivers/net/wireless/wl12xx/cmd.c
>> @@ -129,6 +129,9 @@ int wl1271_cmd_general_parms(struct wl1271 *wl)
>> ? ? ? if (gp->tx_bip_fem_auto_detect)
>> ? ? ? ? ? ? ? answer = true;
>>
>> + ? ? /* Set the ref CLK value */
>> + ? ? gen_parms->general_params.ref_clock = wl->ref_clock;
>> +
>
> The comment is too obvious. ?I think it's better if you say "Override
> the REF CLK from the NVS with the one from platform data".
will be fix

>
>
>> @@ -168,6 +171,13 @@ int wl128x_cmd_general_parms(struct wl1271 *wl)
>> ? ? ? if (gp->tx_bip_fem_auto_detect)
>> ? ? ? ? ? ? ? answer = true;
>>
>> + ? ? /*
>> + ? ? ?* Set the ref CLK & TCXO values.
>> + ? ? ?* The HW will know which of them is the valid one due to boot setting.
>> + ? ? ?*/
>> + ? ? gen_parms->general_params.ref_clock = wl->ref_clock;
>> + ? ? gen_parms->general_params.tcxo_ref_clock = wl->tcxo_clock;
>> +
>
> Same here. ?Please rewrite the comment.
wikll be xi
> ?And "The HW will know which
> one..." is irrelevant here, please remove.
That comment try to clear how the FW know which value (REF or TCXO) is relevant.
I will try to rephrase.

>
> --
> Cheers,
> Luca.
Thanks for your review.

--
All the best,
Shahar

2011-04-01 08:52:50

by Luciano Coelho

Subject: Re: [PATCH] wl12xx: Set correct REF CLK and TCXO CLK values to the FW

On Mon, 2011-03-28 at 09:34 +0200, Shahar Levi wrote:
> Set the correct values to the FW of REF CLK and TCXO CLK from
> wl12xx_platform_data to ini_general_params.
>
> Signed-off-by: Shahar Levi <[email protected]>
> ---

Please rephrase the commit message. Say why we need to do this. The
reason is that we don't want to have a mismatch between the information
that is set in the platform data and the NVS, so we override what comes
from the NVS and replace it with what comes from the platform data.


> diff --git a/drivers/net/wireless/wl12xx/cmd.c b/drivers/net/wireless/wl12xx/cmd.c
> index 2468044..beb9f88 100644
> --- a/drivers/net/wireless/wl12xx/cmd.c
> +++ b/drivers/net/wireless/wl12xx/cmd.c
> @@ -129,6 +129,9 @@ int wl1271_cmd_general_parms(struct wl1271 *wl)
> if (gp->tx_bip_fem_auto_detect)
> answer = true;
>
> + /* Set the ref CLK value */
> + gen_parms->general_params.ref_clock = wl->ref_clock;
> +

The comment is too obvious. I think it's better if you say "Override
the REF CLK from the NVS with the one from platform data".


> @@ -168,6 +171,13 @@ int wl128x_cmd_general_parms(struct wl1271 *wl)
> if (gp->tx_bip_fem_auto_detect)
> answer = true;
>
> + /*
> + * Set the ref CLK & TCXO values.
> + * The HW will know which of them is the valid one due to boot setting.
> + */
> + gen_parms->general_params.ref_clock = wl->ref_clock;
> + gen_parms->general_params.tcxo_ref_clock = wl->tcxo_clock;
> +

Same here. Please rewrite the comment. And "The HW will know which
one..." is irrelevant here, please remove.

--
Cheers,
Luca.