2011-04-08 12:23:19

by Rafał Miłecki

[permalink] [raw]
Subject: [PATCH][2.6.39?] b43: trivial: update module info about firmware

Signed-off-by: Rafał Miłecki <[email protected]>
---
We do not use ucode9, but we started using ucode16_mimo for N-PHY support (high
cores).

John: is that OK to take this for .39?
---
drivers/net/wireless/b43/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 906dfe6..705efd3 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -72,8 +72,8 @@ MODULE_FIRMWARE("b43/ucode11.fw");
MODULE_FIRMWARE("b43/ucode13.fw");
MODULE_FIRMWARE("b43/ucode14.fw");
MODULE_FIRMWARE("b43/ucode15.fw");
+MODULE_FIRMWARE("b43/ucode16_mimo");
MODULE_FIRMWARE("b43/ucode5.fw");
-MODULE_FIRMWARE("b43/ucode9.fw");

static int modparam_bad_frames_preempt;
module_param_named(bad_frames_preempt, modparam_bad_frames_preempt, int, 0444);
--
1.7.3.4



2011-04-08 22:11:56

by Gábor Stefanik

[permalink] [raw]
Subject: Re: [PATCH][2.6.39?] b43: trivial: update module info about firmware

2011/4/8 Michael Büsch <[email protected]>:
> On Fri, 2011-04-08 at 15:00 +0200, Rafał Miłecki wrote:
>> We do not use ucode9,
>
> Well, but we should.
> There are only minor differences between r5 and r9 firmware.
> r9 basically is a r5 firmware with workarounds added that are
> needed for r9 devices.
>
> So I think we should start using r9 instead of removing it here.
>

With a fallback to r5 if no r9 firmware can be found... just to keep
OpenFWWF working.

> --
> Greetings Michael.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2011-04-08 23:16:08

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [PATCH][2.6.39?] b43: trivial: update module info about firmware

W dniu 8 kwietnia 2011 23:58 użytkownik Michael Büsch <[email protected]> napisał:
> On Fri, 2011-04-08 at 15:00 +0200, Rafał Miłecki wrote:
>> We do not use ucode9,
>
> Well, but we should.
> There are only minor differences between r5 and r9 firmware.
> r9 basically is a r5 firmware with workarounds added that are
> needed for r9 devices.
>
> So I think we should start using r9 instead of removing it here.

I meant to add support for loading ucode 9 later and the re-add info
about this. But OK, I'll make V2 which only adds 16_mimo. For normal
development cycle (wireless-testing) I'll add ucode9 loading support.

--
Rafał

2011-04-08 21:58:17

by Michael Büsch

[permalink] [raw]
Subject: Re: [PATCH][2.6.39?] b43: trivial: update module info about firmware

On Fri, 2011-04-08 at 15:00 +0200, Rafał Miłecki wrote:
> We do not use ucode9,

Well, but we should.
There are only minor differences between r5 and r9 firmware.
r9 basically is a r5 firmware with workarounds added that are
needed for r9 devices.

So I think we should start using r9 instead of removing it here.

--
Greetings Michael.


2011-04-08 23:16:24

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [PATCH][2.6.39?] b43: trivial: update module info about firmware

W dniu 9 kwietnia 2011 01:16 użytkownik Rafał Miłecki
<[email protected]> napisał:
> W dniu 8 kwietnia 2011 23:58 użytkownik Michael Büsch <[email protected]> napisał:
>> On Fri, 2011-04-08 at 15:00 +0200, Rafał Miłecki wrote:
>>> We do not use ucode9,
>>
>> Well, but we should.
>> There are only minor differences between r5 and r9 firmware.
>> r9 basically is a r5 firmware with workarounds added that are
>> needed for r9 devices.
>>
>> So I think we should start using r9 instead of removing it here.
>
> I meant to add support for loading ucode 9 later and the re-add info
> about this. But OK, I'll make V2 which only adds 16_mimo. For normal
> development cycle (wireless-testing) I'll add ucode9 loading support.

John: wait for V2 please.

--
Rafał