2011-07-21 19:43:48

by Daniel Drake

Subject: [PATCH] libertas_usb: use USB interface as parent device

Currently, "udevadm info -a -p /sys/class/net/wlan0" doesn't mention
the usb8xxx or libertas driver anywhere. This makes writing udev rules
a bit uncomfortable.

Using the USB interface as the parent device corrects the hierarchy.

Signed-off-by: Daniel Drake <[email protected]>
---
drivers/net/wireless/libertas/if_usb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/libertas/if_usb.c b/drivers/net/wireless/libertas/if_usb.c
index b5acc39..e368b29 100644
--- a/drivers/net/wireless/libertas/if_usb.c
+++ b/drivers/net/wireless/libertas/if_usb.c
@@ -324,7 +324,7 @@ static int if_usb_probe(struct usb_interface *intf,
}
kparam_unblock_sysfs_write(fw_name);

- if (!(priv = lbs_add_card(cardp, &udev->dev)))
+ if (!(priv = lbs_add_card(cardp, &intf->dev)))
goto err_prog_firmware;

cardp->priv = priv;
--
1.7.6

2011-07-27 19:13:21

by Dan Williams

Subject: Re: [PATCH] libertas_usb: use USB interface as parent device

On Thu, 2011-07-21 at 20:43 +0100, Daniel Drake wrote:
> Currently, "udevadm info -a -p /sys/class/net/wlan0" doesn't mention
> the usb8xxx or libertas driver anywhere. This makes writing udev rules
> a bit uncomfortable.
>
> Using the USB interface as the parent device corrects the hierarchy.
>
> Signed-off-by: Daniel Drake <[email protected]>

Acked-by: Dan Williams <[email protected]>

> ---
> drivers/net/wireless/libertas/if_usb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/if_usb.c b/drivers/net/wireless/libertas/if_usb.c
> index b5acc39..e368b29 100644
> --- a/drivers/net/wireless/libertas/if_usb.c
> +++ b/drivers/net/wireless/libertas/if_usb.c
> @@ -324,7 +324,7 @@ static int if_usb_probe(struct usb_interface *intf,
> }
> kparam_unblock_sysfs_write(fw_name);
>
> - if (!(priv = lbs_add_card(cardp, &udev->dev)))
> + if (!(priv = lbs_add_card(cardp, &intf->dev)))
> goto err_prog_firmware;
>
> cardp->priv = priv;