2011-08-02 15:40:00

by Alex Hacker

Subject: [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process.

---
drivers/net/wireless/ath/ath9k/ar9003_phy.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.h b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
index 6de3f0b..5c59042 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.h
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
@@ -850,7 +850,7 @@
#define AR_PHY_TPC_11_B1 (AR_SM1_BASE + 0x220)
#define AR_PHY_PDADC_TAB_1 (AR_SM1_BASE + 0x240)
#define AR_PHY_TX_IQCAL_STATUS_B1 (AR_SM1_BASE + 0x48c)
-#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) (AR_SM_BASE + 0x450 + ((_i) << 2))
+#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) (AR_SM1_BASE + 0x450 + ((_i) << 2))

/*
* Channel 2 Register Map
--
1.7.4

2011-08-02 18:02:30

by John W. Linville

Subject: Re: [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process.

On Tue, Aug 02, 2011 at 09:00:34PM +0600, Alex Hacker wrote:
> ---
> drivers/net/wireless/ath/ath9k/ar9003_phy.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Missing Signed-off-by...

> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.h b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> index 6de3f0b..5c59042 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> @@ -850,7 +850,7 @@
> #define AR_PHY_TPC_11_B1 (AR_SM1_BASE + 0x220)
> #define AR_PHY_PDADC_TAB_1 (AR_SM1_BASE + 0x240)
> #define AR_PHY_TX_IQCAL_STATUS_B1 (AR_SM1_BASE + 0x48c)
> -#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) (AR_SM_BASE + 0x450 + ((_i) << 2))
> +#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) (AR_SM1_BASE + 0x450 + ((_i) << 2))
>
> /*
> * Channel 2 Register Map
> --
> 1.7.4
>
>

--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2011-08-02 20:41:09

by Pavel Roskin

Subject: Re: [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process.

On 08/02/2011 01:50 PM, John W. Linville wrote:
> On Tue, Aug 02, 2011 at 09:00:34PM +0600, Alex Hacker wrote:
>> ---
>> drivers/net/wireless/ath/ath9k/ar9003_phy.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Missing Signed-off-by...

And while at that, the subject line is misspelled, which is ironic for a
patch fixing a typo :)

Also, the subject line should be one compact phrase that fits 80
characters (or even shorter). The period at the end is not needed.
Please check the existing git log. Something like this would be fine:

ath9k: typo fix in ar9003_phy.h that may cause incorrect calibration

--
Regards,
Pavel Roskin