2011-11-09 08:34:20

by Steven Miao

Subject: [PATCH] wireless: libertas: fix unaligned le64 accesses

use get_unaligned_le64() to get timestamp

Signed-off-by: Steven Miao <[email protected]>
---
drivers/net/wireless/libertas/cfg.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c
index b456a53..f23c2b1 100644
--- a/drivers/net/wireless/libertas/cfg.c
+++ b/drivers/net/wireless/libertas/cfg.c
@@ -630,7 +630,7 @@ static int lbs_ret_scan(struct lbs_private *priv, unsigned long dummy,
if (channel &&
!(channel->flags & IEEE80211_CHAN_DISABLED))
cfg80211_inform_bss(wiphy, channel,
- bssid, le64_to_cpu(*(__le64 *)tsfdesc),
+ bssid, get_unaligned_le64(tsfdesc),
capa, intvl, ie, ielen,
LBS_SCAN_RSSI_TO_MBM(rssi),
GFP_KERNEL);
--
1.7.0.4

2011-11-09 17:34:19

by Dan Williams

Subject: Re: [PATCH] wireless: libertas: fix unaligned le64 accesses

On Wed, 2011-11-09 at 16:30 +0800, Steven Miao wrote:
> use get_unaligned_le64() to get timestamp
>
> Signed-off-by: Steven Miao <[email protected]>

Acked-by: Dan Williams <[email protected]>

> ---
> drivers/net/wireless/libertas/cfg.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c
> index b456a53..f23c2b1 100644
> --- a/drivers/net/wireless/libertas/cfg.c
> +++ b/drivers/net/wireless/libertas/cfg.c
> @@ -630,7 +630,7 @@ static int lbs_ret_scan(struct lbs_private *priv, unsigned long dummy,
> if (channel &&
> !(channel->flags & IEEE80211_CHAN_DISABLED))
> cfg80211_inform_bss(wiphy, channel,
> - bssid, le64_to_cpu(*(__le64 *)tsfdesc),
> + bssid, get_unaligned_le64(tsfdesc),
> capa, intvl, ie, ielen,
> LBS_SCAN_RSSI_TO_MBM(rssi),
> GFP_KERNEL);