2011-11-23 16:08:36

by Luis R. Rodriguez

[permalink] [raw]
Subject: [RFC 4/5] brcm80211: avoid code duplication on set tx power

Both cases are doing the same so treat the switch cases
for both as an "or".

Cc: Arend van Spriel <[email protected]>
Signed-off-by: Luis R. Rodriguez <[email protected]>
---
.../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
index fc98981..f23b0c3 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
@@ -1447,12 +1447,6 @@ brcmf_cfg80211_set_tx_power(struct wiphy *wiphy,
case NL80211_TX_POWER_AUTOMATIC:
break;
case NL80211_TX_POWER_LIMITED:
- if (dbm < 0) {
- WL_ERR("TX_POWER_LIMITED - dbm is negative\n");
- err = -EINVAL;
- goto done;
- }
- break;
case NL80211_TX_POWER_FIXED:
if (dbm < 0) {
WL_ERR("TX_POWER_FIXED - dbm is negative\n");
--
1.7.4.15.g7811d