2011-11-30 10:18:18

by Axel Lin

Subject: [PATCH] NFC: pn533: Staticise pn533_data_exchange()

It is not used outside this driver so no need to make the symbol global.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/nfc/pn533.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/nfc/pn533.c b/drivers/nfc/pn533.c
index bd02384..ea10f54 100644
--- a/drivers/nfc/pn533.c
+++ b/drivers/nfc/pn533.c
@@ -1339,7 +1339,7 @@ error:
return 0;
}

-int pn533_data_exchange(struct nfc_dev *nfc_dev, u32 target_idx,
+static int pn533_data_exchange(struct nfc_dev *nfc_dev, u32 target_idx,
struct sk_buff *skb,
data_exchange_cb_t cb,
void *cb_context)
--
1.7.5.4

2011-12-01 19:09:38

by Samuel Ortiz

Subject: Re: [PATCH] NFC: pn533: Staticise pn533_data_exchange()

Hi Axel,

On Wed, Nov 30, 2011 at 06:18:06PM +0800, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Axel Lin <[email protected]>
Acked-by: Samuel Ortiz <[email protected]>

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/