2011-11-30 14:35:46

by Pontus Fuchs

[permalink] [raw]
Subject: [PATCH] wl12xx: Print nvs/fw file name if loading fails.

Print the name of nvs/fw if request_firmware fails. This will make
troubleshooting a bit easier.

Signed-off-by: Pontus Fuchs <[email protected]>
---
drivers/net/wireless/wl12xx/main.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index dbb088e..392dba4 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -1055,7 +1055,7 @@ static int wl1271_fetch_firmware(struct wl1271 *wl)
ret = request_firmware(&fw, fw_name, wl->dev);

if (ret < 0) {
- wl1271_error("could not get firmware: %d", ret);
+ wl1271_error("could not get firmware %s: %d", fw_name, ret);
return ret;
}

@@ -1093,7 +1093,8 @@ static int wl1271_fetch_nvs(struct wl1271 *wl)
ret = request_firmware(&fw, WL12XX_NVS_NAME, wl->dev);

if (ret < 0) {
- wl1271_error("could not get nvs file: %d", ret);
+ wl1271_error("could not get nvs file %s: %d", WL12XX_NVS_NAME,
+ ret);
return ret;
}

--
1.7.5.4



2011-12-01 14:37:52

by Luciano Coelho

[permalink] [raw]
Subject: Re: [PATCH] wl12xx: Print nvs/fw file name if loading fails.

On Wed, 2011-11-30 at 15:35 +0100, Pontus Fuchs wrote:
> Print the name of nvs/fw if request_firmware fails. This will make
> troubleshooting a bit easier.
>
> Signed-off-by: Pontus Fuchs <[email protected]>
> ---

Applied.

--
Cheers,
Luca.