2011-12-13 08:57:16

by Mohammed Shafi Shajakhan

Subject: [RFC 1/2] mac80211: remove an unnecessary paraenthesis

From: Mohammed Shafi Shajakhan <[email protected]>

Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
---
net/mac80211/mlme.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 09019d1..67a6be1 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -819,7 +819,7 @@ void ieee80211_dynamic_ps_enable_work(struct work_struct *work)
}

if ((local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK) &&
- (!(ifmgd->flags & IEEE80211_STA_NULLFUNC_ACKED))) {
+ !(ifmgd->flags & IEEE80211_STA_NULLFUNC_ACKED)) {
netif_tx_stop_all_queues(sdata->dev);

if (drv_tx_frames_pending(local))
--
1.7.0.4

2011-12-13 08:57:27

by Johannes Berg

Subject: Re: [RFC 2/2] mac80211: Fix power save in change save

On Tue, 2011-12-13 at 14:25 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <[email protected]>
>
> we found that power save is not getting enabled when we do
> change interface in this order STA->IBSS->STA. this is
> because ieee80211_setup_sdata clears type-dependen union
>
> Reported-by: Leela Kella <[email protected]>
> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
> ---
> net/mac80211/mlme.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 67a6be1..d87fde3 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -2371,6 +2371,7 @@ void ieee80211_sta_setup_sdata(struct ieee80211_sub_if_data *sdata)
> (unsigned long) sdata);
>
> ifmgd->flags = 0;
> + ifmgd->powersave = sdata->wdev.ps;

Makes sense.

johannes

2011-12-13 09:07:38

by Mohammed Shafi Shajakhan

Subject: Re: [RFC 2/2] mac80211: Fix power save in change save

Hi Johannes,

On Tuesday 13 December 2011 02:27 PM, Johannes Berg wrote:
> On Tue, 2011-12-13 at 14:25 +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<[email protected]>
>>
>> we found that power save is not getting enabled when we do
>> change interface in this order STA->IBSS->STA. this is
>> because ieee80211_setup_sdata clears type-dependen union
>>
>> Reported-by: Leela Kella<[email protected]>
>> Signed-off-by: Mohammed Shafi Shajakhan<[email protected]>
>> ---
>> net/mac80211/mlme.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
>> index 67a6be1..d87fde3 100644
>> --- a/net/mac80211/mlme.c
>> +++ b/net/mac80211/mlme.c
>> @@ -2371,6 +2371,7 @@ void ieee80211_sta_setup_sdata(struct ieee80211_sub_if_data *sdata)
>> (unsigned long) sdata);
>>
>> ifmgd->flags = 0;
>> + ifmgd->powersave = sdata->wdev.ps;
>
> Makes sense.

thanks for the review, I will fix the subject name also.

>
> johannes
>


--
thanks,
shafi

2011-12-13 08:55:39

by Mohammed Shafi Shajakhan

Subject: [RFC 2/2] mac80211: Fix power save in change save

From: Mohammed Shafi Shajakhan <[email protected]>

we found that power save is not getting enabled when we do
change interface in this order STA->IBSS->STA. this is
because ieee80211_setup_sdata clears type-dependen union

Reported-by: Leela Kella <[email protected]>
Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
---
net/mac80211/mlme.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 67a6be1..d87fde3 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -2371,6 +2371,7 @@ void ieee80211_sta_setup_sdata(struct ieee80211_sub_if_data *sdata)
(unsigned long) sdata);

ifmgd->flags = 0;
+ ifmgd->powersave = sdata->wdev.ps;

mutex_init(&ifmgd->mtx);

--
1.7.0.4