Subject: [PATCH] ath6kl: Change ielen in ath6kl_add_new_sta() from u8 to size_t

Otherwise if (ielen <= ATH6KL_MAX_IE) is dead code. It looks safe to
change the type of ielen from u8 to size_t instead of removing this
if check, this ielen can have the length of more than one ies in future.

Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
---
drivers/net/wireless/ath/ath6kl/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
index c44eca2..347e987 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -53,7 +53,7 @@ struct ath6kl_sta *ath6kl_find_sta_by_aid(struct ath6kl *ar, u8 aid)
}

static void ath6kl_add_new_sta(struct ath6kl *ar, u8 *mac, u16 aid, u8 *wpaie,
- u8 ielen, u8 keymgmt, u8 ucipher, u8 auth)
+ size_t ielen, u8 keymgmt, u8 ucipher, u8 auth)
{
struct ath6kl_sta *sta;
u8 free_slot;
--
1.7.0.4



2012-01-09 10:47:49

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath6kl: Change ielen in ath6kl_add_new_sta() from u8 to size_t

On 01/03/2012 11:58 AM, Vasanthakumar Thiagarajan wrote:
> Otherwise if (ielen <= ATH6KL_MAX_IE) is dead code. It looks safe to
> change the type of ielen from u8 to size_t instead of removing this
> if check, this ielen can have the length of more than one ies in future.
>
> Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>

Thanks, applied.

Kalle