2012-01-30 13:41:24

by Masanari Iida

Subject: [PATCH] [trivial] net: Fix typo in rtl8192de/dm.c

Correct spelling "disconnet" to "disconnect" in
drivers/net/wireless/rtlwifi/rtl8192de/dm.c

Signed-off-by: Masanari Iida <[email protected]>
---
drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
index 3cd0736..5087fe4 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
@@ -296,7 +296,7 @@ static void rtl92d_dm_find_minimum_rssi(struct ieee80211_hw *hw)
de_digtable.min_undecorated_pwdb_for_dm =
rtlpriv->dm.UNDEC_SM_PWDB;
RT_TRACE(rtlpriv, COMP_BB_POWERSAVING, DBG_LOUD,
- ("AP Ext Port or disconnet PWDB = 0x%x\n",
+ ("AP Ext Port or disconnect PWDB = 0x%x\n",
de_digtable.min_undecorated_pwdb_for_dm));
}

--
1.7.6.5

2012-01-30 15:31:06

by Larry Finger

Subject: Re: [PATCH] [trivial] net: Fix typo in rtl8192de/dm.c

On 01/30/2012 07:40 AM, Masanari Iida wrote:
> Correct spelling "disconnet" to "disconnect" in
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c
>
> Signed-off-by: Masanari Iida<[email protected]>
> ---
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

The patch is OK, but by convention, the subject should say "[PATCH] rtlwifi:
rtl8192dm: Fix typo in dm.c". By getting rtlwifi in it, searching the git log is
a lot easier.

Larry

>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> index 3cd0736..5087fe4 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> @@ -296,7 +296,7 @@ static void rtl92d_dm_find_minimum_rssi(struct ieee80211_hw *hw)
> de_digtable.min_undecorated_pwdb_for_dm =
> rtlpriv->dm.UNDEC_SM_PWDB;
> RT_TRACE(rtlpriv, COMP_BB_POWERSAVING, DBG_LOUD,
> - ("AP Ext Port or disconnet PWDB = 0x%x\n",
> + ("AP Ext Port or disconnect PWDB = 0x%x\n",
> de_digtable.min_undecorated_pwdb_for_dm));
> }
>

2012-01-30 16:03:04

by Masanari Iida

Subject: Re: [PATCH] [trivial] net: Fix typo in rtl8192de/dm.c

On Tue, Jan 31, 2012 at 12:31 AM, Larry Finger
<[email protected]> wrote:
> On 01/30/2012 07:40 AM, Masanari Iida wrote:
>>
>> Correct spelling "disconnet" to "disconnect" in
>> drivers/net/wireless/rtlwifi/rtl8192de/dm.c
>>
>> Signed-off-by: Masanari Iida<[email protected]>
>> ---
>> ?drivers/net/wireless/rtlwifi/rtl8192de/dm.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> The patch is OK, but by convention, the subject should say "[PATCH] rtlwifi:
> rtl8192dm: Fix typo in dm.c". By getting rtlwifi in it, searching the git
> log is a lot easier.
>
> Larry
>
I will re-post this with correct subject.
Masanari

2012-01-30 16:21:04

by Joe Perches

Subject: Re: [PATCH] [trivial] net: Fix typo in rtl8192de/dm.c

On Tue, 2012-01-31 at 01:03 +0900, Masanari Iida wrote:
> I will re-post this with correct subject.

Better to redo this against linux-next too.
RT_TRACE has changed.