2012-02-06 15:38:35

by Sid Hayn

[permalink] [raw]
Subject: [PATCH] Calling make directly is not permitted

make was being called directly, fix to $(MAKE)

Signed-of-By: Rick Farina <[email protected]>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index d586f45..440bd91 100644
--- a/Makefile
+++ b/Makefile
@@ -115,7 +115,7 @@ btuninstall:
@echo

btclean:
- make -C /lib/modules/$(shell uname -r)/build M=$(PWD) BT=TRUE clean
+ $(MAKE) -C /lib/modules/$(shell uname -r)/build M=$(PWD) BT=TRUE clean
@rm -f $(CREL_PRE)*

install: uninstall install-modules install-scripts
--
1.7.3.4



2012-02-06 15:52:51

by Sid Hayn

[permalink] [raw]
Subject: Re: [PATCH] Calling make directly is not permitted

On 02/06/12 10:38, Rick Farina wrote:

I apologize, both this patch and my "add missing =y" patch should have
had compat-wireless in the subject line. I'm still learning to use git
send-email.

Anyone want to tell me how to make git stop add myself to the cc just
because the SOB line is in the commit message? Am I supposed to add the
SOB some other way?

Thanks!

-Rick
> make was being called directly, fix to $(MAKE)
>
> Signed-of-By: Rick Farina <[email protected]>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index d586f45..440bd91 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -115,7 +115,7 @@ btuninstall:
> @echo
>
> btclean:
> - make -C /lib/modules/$(shell uname -r)/build M=$(PWD) BT=TRUE clean
> + $(MAKE) -C /lib/modules/$(shell uname -r)/build M=$(PWD) BT=TRUE clean
> @rm -f $(CREL_PRE)*
>
> install: uninstall install-modules install-scripts


2012-02-06 16:03:59

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] Calling make directly is not permitted

On 02/06/2012 09:38 AM, Rick Farina wrote:
> make was being called directly, fix to $(MAKE)
>
> Signed-of-By: Rick Farina<[email protected]>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

In your subject line, please indicate what component is being patched. From the
context, I think it is compat-wireless, but why should I have to guess?

Larry

2012-02-07 21:55:32

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [PATCH] Calling make directly is not permitted

On Mon, Feb 6, 2012 at 7:38 AM, Rick Farina <[email protected]> wrote:
> make was being called directly, fix to $(MAKE)
>
> Signed-of-By: Rick Farina <[email protected]>

applied and pushed, thanks!

Luis