2012-02-06 15:42:37

by Sid Hayn

Subject: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

When editing config.mk with a sed script the missing =y on this line
causes issue. Since this line is commented out by default this means no
changes to the default behavior and sed scripts will be able to edit the
config.mk file much more easily.

Signed-of-By: Rick Farina <[email protected]>
---
config.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/config.mk b/config.mk
index 9433ce9..a9d189e 100644
--- a/config.mk
+++ b/config.mk
@@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
endif #CONFIG_LEDS_CLASS
endif #CONFIG_COMPAT_KERNEL_2_6_25
# CONFIG_RT2X00_DEBUG=y
-# CONFIG_RT2X00_LIB_DEBUGFS
+# CONFIG_RT2X00_LIB_DEBUGFS=y
endif

# p54
--
1.7.3.4

2012-02-07 21:57:28

by Luis R. Rodriguez

Subject: Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

On Mon, Feb 6, 2012 at 7:42 AM, Rick Farina <[email protected]> wrote:
> When editing config.mk with a sed script the missing =y on this line
> causes issue. Since this line is commented out by default this means no
> changes to the default behavior and sed scripts will be able to edit the
> config.mk file much more easily.
>
> Signed-of-By: Rick Farina <[email protected]>

Applied and pushed, thanks!

Luis

2012-02-06 16:42:52

by Sid Hayn

Subject: Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

On 02/06/12 11:16, John W. Linville wrote:
> On Mon, Feb 06, 2012 at 10:42:16AM -0500, Rick Farina wrote:
>> When editing config.mk with a sed script the missing =y on this line
>> causes issue. Since this line is commented out by default this means no
>> changes to the default behavior and sed scripts will be able to edit the
>> config.mk file much more easily.
>>
>> Signed-of-By: Rick Farina <[email protected]>
>> ---
>> config.mk | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/config.mk b/config.mk
>> index 9433ce9..a9d189e 100644
>> --- a/config.mk
>> +++ b/config.mk
>> @@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
>> endif #CONFIG_LEDS_CLASS
>> endif #CONFIG_COMPAT_KERNEL_2_6_25
>> # CONFIG_RT2X00_DEBUG=y
>> -# CONFIG_RT2X00_LIB_DEBUGFS
>> +# CONFIG_RT2X00_LIB_DEBUGFS=y
>> endif
>>
>> # p54
> Isn't it more common to say "is not set" for Kconfig stuff that is commented out?
>
You are completely correct, however in this case that is not used on any
of the other lines. This change makes the style consistent across
compat-wireless not across the kernel.

Thanks,
Rick

2012-02-06 16:31:31

by John W. Linville

Subject: Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS

On Mon, Feb 06, 2012 at 10:42:16AM -0500, Rick Farina wrote:
> When editing config.mk with a sed script the missing =y on this line
> causes issue. Since this line is commented out by default this means no
> changes to the default behavior and sed scripts will be able to edit the
> config.mk file much more easily.
>
> Signed-of-By: Rick Farina <[email protected]>
> ---
> config.mk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/config.mk b/config.mk
> index 9433ce9..a9d189e 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
> endif #CONFIG_LEDS_CLASS
> endif #CONFIG_COMPAT_KERNEL_2_6_25
> # CONFIG_RT2X00_DEBUG=y
> -# CONFIG_RT2X00_LIB_DEBUGFS
> +# CONFIG_RT2X00_LIB_DEBUGFS=y
> endif
>
> # p54

Isn't it more common to say "is not set" for Kconfig stuff that is commented out?

--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.