2012-02-13 14:13:10

by Johannes Berg

Subject: RTLWIFI_DEBUG bug

config RTLWIFI_DEBUG
tristate "Additional debugging output"
depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
default y

should be

config RTLWIFI_DEBUG
bool "..."

as otherwise

+#ifdef CONFIG_RTLWIFI_DEBUG

can never be true in a modular build.

johannes

2012-02-13 20:35:28

by Joe Perches

Subject: Re: RTLWIFI_DEBUG bug

On Mon, 2012-02-13 at 15:13 +0100, Johannes Berg wrote:
> config RTLWIFI_DEBUG
> tristate "Additional debugging output"
> depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> default y
>
> should be
>
> config RTLWIFI_DEBUG
> bool "..."
>
> as otherwise
>
> +#ifdef CONFIG_RTLWIFI_DEBUG
> can never be true in a modular build.

If you know the correct solution,
perhaps you should submit a patch.

2012-02-14 07:36:40

by Johannes Berg

Subject: Re: RTLWIFI_DEBUG bug

On Mon, 2012-02-13 at 15:45 -0600, Larry Finger wrote:
> On 02/13/2012 08:13 AM, Johannes Berg wrote:
> > config RTLWIFI_DEBUG
> > tristate "Additional debugging output"
> > depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> > default y
> >
> > should be
> >
> > config RTLWIFI_DEBUG
> > bool "..."
> >
> > as otherwise
> >
> > +#ifdef CONFIG_RTLWIFI_DEBUG
> >
> > can never be true in a modular build.
> >
> > johannes
>
> Johannes,
>
> It is OK as is. The appropriate section of my .config has
>
> CONFIG_RTL8192CE=m
> CONFIG_RTL8192SE=m
> CONFIG_RTL8192DE=m
> CONFIG_RTL8192CU=m
> CONFIG_RTLWIFI=m
> CONFIG_RTLWIFI_DEBUG=m

Kconfig wise it is fine, but you might as well unset it -- the only use
is an #ifdef which will not match when it's set to m.

johannes

2012-02-14 01:49:02

by Joe Perches

Subject: Re: RTLWIFI_DEBUG bug

On Mon, 2012-02-13 at 22:07 +0100, Johannes Berg wrote:
> On Mon, 2012-02-13 at 12:35 -0800, Joe Perches wrote:
> > On Mon, 2012-02-13 at 15:13 +0100, Johannes Berg wrote:
> > > config RTLWIFI_DEBUG
> > > tristate "Additional debugging output"
> > > depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> > > default y
> > >
> > > should be
> > >
> > > config RTLWIFI_DEBUG
> > > bool "..."
> > >
> > > as otherwise
> > >
> > > +#ifdef CONFIG_RTLWIFI_DEBUG
> > > can never be true in a modular build.
> >
> > If you know the correct solution,
> > perhaps you should submit a patch.
>
> If I knew your attitude was going to be a problem, I'd never said
> anything. I have better things to do.

If you know a problem exists and the
proper solution, it's not necessary to
do anything other than create the
appropriate patch and cc the appropriate
people. Doing something else just creates
more work for more people.

2012-02-13 21:45:13

by Larry Finger

Subject: Re: RTLWIFI_DEBUG bug

On 02/13/2012 08:13 AM, Johannes Berg wrote:
> config RTLWIFI_DEBUG
> tristate "Additional debugging output"
> depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> default y
>
> should be
>
> config RTLWIFI_DEBUG
> bool "..."
>
> as otherwise
>
> +#ifdef CONFIG_RTLWIFI_DEBUG
>
> can never be true in a modular build.
>
> johannes

Johannes,

It is OK as is. The appropriate section of my .config has

CONFIG_RTL8192CE=m
CONFIG_RTL8192SE=m
CONFIG_RTL8192DE=m
CONFIG_RTL8192CU=m
CONFIG_RTLWIFI=m
CONFIG_RTLWIFI_DEBUG=m
CONFIG_RTL8192C_COMMON=m

Larry

2012-02-13 21:07:29

by Johannes Berg

Subject: Re: RTLWIFI_DEBUG bug

On Mon, 2012-02-13 at 12:35 -0800, Joe Perches wrote:
> On Mon, 2012-02-13 at 15:13 +0100, Johannes Berg wrote:
> > config RTLWIFI_DEBUG
> > tristate "Additional debugging output"
> > depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> > default y
> >
> > should be
> >
> > config RTLWIFI_DEBUG
> > bool "..."
> >
> > as otherwise
> >
> > +#ifdef CONFIG_RTLWIFI_DEBUG
> > can never be true in a modular build.
>
> If you know the correct solution,
> perhaps you should submit a patch.

If I knew your attitude was going to be a problem, I'd never said
anything. I have better things to do.

johannes