2012-04-20 18:33:15

by Thomas Pedersen

Subject: [PATCH] ath6kl: unblock fwlog_block_read() on exit

Complete the waiting fwlog_block_read on debugfs cleanup, otherwise
userspace and module unload might softlock.

Signed-off-by: Thomas Pedersen <[email protected]>
---
drivers/net/wireless/ath/ath6kl/debug.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
index fed3232..15cfe30 100644
--- a/drivers/net/wireless/ath/ath6kl/debug.c
+++ b/drivers/net/wireless/ath/ath6kl/debug.c
@@ -1818,6 +1818,7 @@ int ath6kl_debug_init_fs(struct ath6kl *ar)
void ath6kl_debug_cleanup(struct ath6kl *ar)
{
skb_queue_purge(&ar->debug.fwlog_queue);
+ complete(&ar->debug.fwlog_completion);
kfree(ar->debug.roam_tbl);
}

--
1.7.4.1

2012-04-23 11:39:49

by Kalle Valo

Subject: Re: [PATCH] ath6kl: unblock fwlog_block_read() on exit

On 04/20/2012 09:33 PM, Thomas Pedersen wrote:
> Complete the waiting fwlog_block_read on debugfs cleanup, otherwise
> userspace and module unload might softlock.
>
> Signed-off-by: Thomas Pedersen <[email protected]>

Thanks, applied.

Kalle