2012-05-03 05:13:38

by Marcel Holtmann

Subject: [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

The SHDLC link layer of HCI based drivers uses CRC-CCITT and thus
needs to select that kernel option.

Otherwise it ends up with this linking error:

net/built-in.o: In function `nfc_shdlc_add_len_crc':
net/nfc/hci/shdlc.c:113: undefined reference to `crc_ccitt'

Signed-off-by: Marcel Holtmann <[email protected]>
---
net/nfc/hci/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/nfc/hci/Kconfig b/net/nfc/hci/Kconfig
index 17213a6..fd67f51 100644
--- a/net/nfc/hci/Kconfig
+++ b/net/nfc/hci/Kconfig
@@ -9,6 +9,7 @@ config NFC_HCI

config NFC_SHDLC
depends on NFC_HCI
+ select CRC_CCITT
bool "SHDLC link layer for HCI based NFC drivers"
default n
---help---
--
1.7.7.6

2012-05-03 20:37:15

by Marcel Holtmann

Subject: Re: [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

Hi John,

> Was there a [PATCH 1/2]? I didn't get it...

yes, but it was a Bluetooth one :)

Regards

Marcel

2012-05-07 08:23:52

by Samuel Ortiz

Subject: Re: [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

Hi Marcel,

On Thu, 2012-05-03 at 07:12 +0200, Marcel Holtmann wrote:
> The SHDLC link layer of HCI based drivers uses CRC-CCITT and thus
> needs to select that kernel option.
>
> Otherwise it ends up with this linking error:
>
> net/built-in.o: In function `nfc_shdlc_add_len_crc':
> net/nfc/hci/shdlc.c:113: undefined reference to `crc_ccitt'
>
> Signed-off-by: Marcel Holtmann <[email protected]>
Acked-by: Samuel Ortiz <[email protected]>

Cheers,
Samuel.

2012-05-03 13:47:51

by John W. Linville

Subject: Re: [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

Was there a [PATCH 1/2]? I didn't get it...

On Thu, May 03, 2012 at 07:12:48AM +0200, Marcel Holtmann wrote:
> The SHDLC link layer of HCI based drivers uses CRC-CCITT and thus
> needs to select that kernel option.
>
> Otherwise it ends up with this linking error:
>
> net/built-in.o: In function `nfc_shdlc_add_len_crc':
> net/nfc/hci/shdlc.c:113: undefined reference to `crc_ccitt'
>
> Signed-off-by: Marcel Holtmann <[email protected]>
> ---
> net/nfc/hci/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/nfc/hci/Kconfig b/net/nfc/hci/Kconfig
> index 17213a6..fd67f51 100644
> --- a/net/nfc/hci/Kconfig
> +++ b/net/nfc/hci/Kconfig
> @@ -9,6 +9,7 @@ config NFC_HCI
>
> config NFC_SHDLC
> depends on NFC_HCI
> + select CRC_CCITT
> bool "SHDLC link layer for HCI based NFC drivers"
> default n
> ---help---
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.