2012-06-14 07:49:13

by Arik Nemtsov

Subject: [RFC] mac80211: set only VO as a U-APSD enabled AC

Some APs experience problems when working with U-APSD. Decrease the
probability of that happening by using legacy mode for all ACs but VO.

The AP that caused us troubles was a Cisco 4410N. It ignores our
setting, and always treats non-VO ACs as legacy.

Signed-off-by: Arik Nemtsov <[email protected]>
---
Let's have another go at this :)

net/mac80211/ieee80211_i.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index ddf768f..58436c3 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -56,10 +56,7 @@ struct ieee80211_local;
#define TU_TO_EXP_TIME(x) (jiffies + TU_TO_JIFFIES(x))

#define IEEE80211_DEFAULT_UAPSD_QUEUES \
- (IEEE80211_WMM_IE_STA_QOSINFO_AC_BK | \
- IEEE80211_WMM_IE_STA_QOSINFO_AC_BE | \
- IEEE80211_WMM_IE_STA_QOSINFO_AC_VI | \
- IEEE80211_WMM_IE_STA_QOSINFO_AC_VO)
+ IEEE80211_WMM_IE_STA_QOSINFO_AC_VO

#define IEEE80211_DEFAULT_MAX_SP_LEN \
IEEE80211_WMM_IE_STA_QOSINFO_SP_ALL
--
1.7.9.5

2012-06-14 08:11:43

by Kalle Valo

Subject: Re: [RFC] mac80211: set only VO as a U-APSD enabled AC

Arik Nemtsov <[email protected]> writes:

> Some APs experience problems when working with U-APSD. Decrease the
> probability of that happening by using legacy mode for all ACs but VO.
>
> The AP that caused us troubles was a Cisco 4410N. It ignores our
> setting, and always treats non-VO ACs as legacy.
>
> Signed-off-by: Arik Nemtsov <[email protected]>
> ---
> Let's have another go at this :)

Looks good to me :)

> #define IEEE80211_DEFAULT_UAPSD_QUEUES \
> - (IEEE80211_WMM_IE_STA_QOSINFO_AC_BK | \
> - IEEE80211_WMM_IE_STA_QOSINFO_AC_BE | \
> - IEEE80211_WMM_IE_STA_QOSINFO_AC_VI | \
> - IEEE80211_WMM_IE_STA_QOSINFO_AC_VO)
> + IEEE80211_WMM_IE_STA_QOSINFO_AC_VO

A comment why we only enable VO would be nice.

--
Kalle Valo