2012-07-02 11:30:59

by Sasha Levin

[permalink] [raw]
Subject: [PATCH] NFC: Don't warn when closing uninitialized socket

It is possible to close a NFC socket without initializing it first,
there's no need to warn about it.

Signed-off-by: Sasha Levin <[email protected]>
---
net/nfc/llcp/llcp.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c
index 5d503ee..cf84544 100644
--- a/net/nfc/llcp/llcp.c
+++ b/net/nfc/llcp/llcp.c
@@ -118,8 +118,6 @@ static void local_release(struct kref *ref)

int nfc_llcp_local_put(struct nfc_llcp_local *local)
{
- WARN_ON(local == NULL);
-
if (local == NULL)
return 0;

--
1.7.8.6



2012-07-05 15:34:33

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH] NFC: Don't warn when closing uninitialized socket

Hi Sasha,

On Mon, Jul 02, 2012 at 01:31:42PM +0200, Sasha Levin wrote:
> It is possible to close a NFC socket without initializing it first,
> there's no need to warn about it.
>
> Signed-off-by: Sasha Levin <[email protected]>
> ---
> net/nfc/llcp/llcp.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
I already fixed this one, with your reported-by.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/