2012-09-26 15:27:42

by Randy Dunlap

[permalink] [raw]
Subject: Re: inux-next: Tree for Sept 26 (nfc)

On 09/25/2012 11:44 PM, Stephen Rothwell wrote:

> Hi all,
>
> Changes since 201209025:
>



on x86_64:

ERROR: "nfc_llc_shdlc_register" [net/nfc/hci/hci.ko] undefined!


Full randconfig file is attached.

--
~Randy


Attachments:
config-r7799 (47.50 kB)

2012-09-26 17:40:05

by John W. Linville

[permalink] [raw]
Subject: [PATCH] nfc: add dummy nfc_llc_shdlc_register definition

From: "John W. Linville" <[email protected]>

This is used when CONFIG_NFC_SHDLC is disabled.

Reported-by: Randy Dunlap <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
---
net/nfc/hci/llc.h | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/net/nfc/hci/llc.h b/net/nfc/hci/llc.h
index c7014fd..7be0b7f 100644
--- a/net/nfc/hci/llc.h
+++ b/net/nfc/hci/llc.h
@@ -56,6 +56,14 @@ int nfc_llc_register(const char *name, struct nfc_llc_ops *ops);
void nfc_llc_unregister(const char *name);

int nfc_llc_nop_register(void);
+
+#if defined(CONFIG_NFC_SHDLC)
int nfc_llc_shdlc_register(void);
+#else
+static inline int nfc_llc_shdlc_register(void)
+{
+ return 0;
+}
+#endif

#endif /* __LOCAL_LLC_H_ */
--
1.7.11.4


2012-09-27 07:12:07

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH] nfc: add dummy nfc_llc_shdlc_register definition

Hi John,

On Wed, Sep 26, 2012 at 01:39:10PM -0400, John W. Linville wrote:
> From: "John W. Linville" <[email protected]>
>
> This is used when CONFIG_NFC_SHDLC is disabled.
>
> Reported-by: Randy Dunlap <[email protected]>
Acked-by: Samuel Ortiz <[email protected]>
> Signed-off-by: John W. Linville <[email protected]>
> ---
> net/nfc/hci/llc.h | 8 ++++++++
> 1 file changed, 8 insertions(+)

Thanks a lot for fixing this one up.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/