From: Mohammed Shafi Shajakhan <[email protected]>
Set HT capabilites when a vif is added (based on ht_supported
advertized is 'true'). ath6kl_set_htcap
seems to be called when an AP vif is added but not so in
other vifs. Fix this.
Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index d6e6c2d..5c3aaf6 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -3630,6 +3630,8 @@ struct wireless_dev *ath6kl_interface_add(struct ath6kl *ar, char *name,
list_add_tail(&vif->list, &ar->vif_list);
spin_unlock_bh(&ar->list_lock);
+ ath6kl_restore_htcap(vif);
+
return &vif->wdev;
err:
--
1.7.0.4
Mohammed Shafi Shajakhan <[email protected]> writes:
> From: Mohammed Shafi Shajakhan <[email protected]>
>
> Set HT capabilites when a vif is added (based on ht_supported
> advertized is 'true'). ath6kl_set_htcap
> seems to be called when an AP vif is added but not so in
> other vifs. Fix this.
>
> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
This was found during code review, right? Or does it fix a real bug?
Kalle
Hi Kalle,
On Sunday 21 October 2012 03:28 PM, Kalle Valo wrote:
> Mohammed Shafi Shajakhan <[email protected]> writes:
>
>> From: Mohammed Shafi Shajakhan <[email protected]>
>>
>> Set HT capabilites when a vif is added (based on ht_supported
>> advertized is 'true'). ath6kl_set_htcap
>> seems to be called when an AP vif is added but not so in
>> other vifs. Fix this.
>>
>> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
>
> This was found during code review, right? Or does it fix a real bug?
yes this was based on code review, would soon come with some test
results with multivif.
>
--
thanks,
shafi
Hi Kalle,
On Friday 16 November 2012 05:01 PM, Kalle Valo wrote:
> Hi,
>
> On 10/22/2012 08:25 AM, Mohammed Shafi Shajakhan wrote:
>> On Sunday 21 October 2012 03:28 PM, Kalle Valo wrote:
>>> Mohammed Shafi Shajakhan <[email protected]> writes:
>>>
>>>> From: Mohammed Shafi Shajakhan <[email protected]>
>>>>
>>>> Set HT capabilites when a vif is added (based on ht_supported
>>>> advertized is 'true'). ath6kl_set_htcap
>>>> seems to be called when an AP vif is added but not so in
>>>> other vifs. Fix this.
>>>>
>>>> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
>>>
>>> This was found during code review, right? Or does it fix a real bug?
>>
>> yes this was based on code review, would soon come with some test
>> results with multivif.
>
> I'm not sure what was the conclusion, is this safe to apply?
Sorry i missed this, yeah will confirm it soon with a basic test and let
you know. Please don't apply till that. thanks for your patience :)
>
> Kalle
>
--
thanks,
shafi
Hi,
On 10/22/2012 08:25 AM, Mohammed Shafi Shajakhan wrote:
> On Sunday 21 October 2012 03:28 PM, Kalle Valo wrote:
>> Mohammed Shafi Shajakhan <[email protected]> writes:
>>
>>> From: Mohammed Shafi Shajakhan <[email protected]>
>>>
>>> Set HT capabilites when a vif is added (based on ht_supported
>>> advertized is 'true'). ath6kl_set_htcap
>>> seems to be called when an AP vif is added but not so in
>>> other vifs. Fix this.
>>>
>>> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
>>
>> This was found during code review, right? Or does it fix a real bug?
>
> yes this was based on code review, would soon come with some test
> results with multivif.
I'm not sure what was the conclusion, is this safe to apply?
Kalle