2012-11-08 08:47:53

by Piotr Haber

[permalink] [raw]
Subject: [PATCH] ssb: fix SPROM offset

Offset for temperature compensation
values is wrong in ssb SPROMv8 map.

Reviewed-by: Pieter-Paul Giesberts <[email protected]>
Reviewed-by: Arend van Spriel <[email protected]>
Signed-off-by: Piotr Haber <[email protected]>
---
include/linux/ssb/ssb_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/ssb/ssb_regs.h b/include/linux/ssb/ssb_regs.h
index a052501..6ecfa02 100644
--- a/include/linux/ssb/ssb_regs.h
+++ b/include/linux/ssb/ssb_regs.h
@@ -485,7 +485,7 @@
#define SSB_SPROM8_HWIQ_IQSWP_IQCAL_SWP_SHIFT 4
#define SSB_SPROM8_HWIQ_IQSWP_HW_IQCAL 0x0020
#define SSB_SPROM8_HWIQ_IQSWP_HW_IQCAL_SHIFT 5
-#define SSB_SPROM8_TEMPDELTA 0x00BA
+#define SSB_SPROM8_TEMPDELTA 0x00BC
#define SSB_SPROM8_TEMPDELTA_PHYCAL 0x00ff
#define SSB_SPROM8_TEMPDELTA_PHYCAL_SHIFT 0
#define SSB_SPROM8_TEMPDELTA_PERIOD 0x0f00
--
1.7.9.5




2012-11-08 17:53:18

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [PATCH] ssb: fix SPROM offset

2012/11/8 Piotr Haber <[email protected]>:
> Offset for temperature compensation
> values is wrong in ssb SPROMv8 map.

Thanks, you can also take a look at "Wrong offset for
SSB_SPROM4_ANTAVAIL?" thread:
http://lists.infradead.org/pipermail/b43-dev/2011-April/001041.html
Not sure if that mistakes were fixed.

--
Rafał

2012-11-11 20:41:35

by Hauke Mehrtens

[permalink] [raw]
Subject: Re: [PATCH] ssb: fix SPROM offset

On 11/08/2012 06:53 PM, Rafał Miłecki wrote:
> 2012/11/8 Piotr Haber <[email protected]>:
>> Offset for temperature compensation
>> values is wrong in ssb SPROMv8 map.
>
> Thanks, you can also take a look at "Wrong offset for
> SSB_SPROM4_ANTAVAIL?" thread:
> http://lists.infradead.org/pipermail/b43-dev/2011-April/001041.html
> Not sure if that mistakes were fixed.
>
Hi

yes SSB_SPROM4_ANTAVAIL is wrong, I updated the wiki page [0] for sprom
to match the table from the driver/SoC SDK version 6.30.39.31. The table
is mostly automatically generated from the structures broadcom uses in
their driver, this is from the ISC licensed part.

Hauke

[0]: http://bcm-v4.sipsolutions.net/SPROM