2013-02-05 20:45:15

by Malcolm Priestley

Subject: [PATCH] staging: vt6656: Fix sparse warning constant 0xffffffff00000000U is so big it is unsigned long

long long is needed for u64.

Signed-off-by: Malcolm Priestley <[email protected]>
---
drivers/staging/vt6656/card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index 7d725bb..4e8fcc9 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -790,7 +790,7 @@ u64 CARDqGetNextTBTT(u64 qwTSF, WORD wBeaconInterval)
if ((~uLowNextTBTT) < uLowRemain)
qwTSF = ((qwTSF >> 32) + 1) << 32;

- qwTSF = (qwTSF & 0xffffffff00000000U) |
+ qwTSF = (qwTSF & 0xffffffff00000000ULL) |
(u64)(uLowNextTBTT + uLowRemain);

return (qwTSF);
--
1.8.0

2013-02-05 21:35:51

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: vt6656: Fix sparse warning constant 0xffffffff00000000U is so big it is unsigned long

On Tue, Feb 05, 2013 at 08:45:07PM +0000, Malcolm Priestley wrote:
>
> long long is needed for u64.
>
> Signed-off-by: Malcolm Priestley <[email protected]>
> ---
> drivers/staging/vt6656/card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

You forgot to add a "Reported-by:" line to this patch, please do so and
resend.

thanks,

greg k-h