2013-05-31 05:29:55

by Nikolay Martynov

[permalink] [raw]
Subject: [PATCH] iwlwifi: fix chain noise calibration

First step of chain noise calibration process had disable flag check inverted.
Chain noise calibration never started because of this.

Tested on intel 5300 with two antennas attached. Driver correctly disabled one chain.

Signed-off-by: Nikolay Martynov <[email protected]>
---
drivers/net/wireless/iwlwifi/dvm/rxon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/iwlwifi/dvm/rxon.c b/drivers/net/wireless/iwlwifi/dvm/rxon.c
index 707446f..cd1ad001 100644
--- a/drivers/net/wireless/iwlwifi/dvm/rxon.c
+++ b/drivers/net/wireless/iwlwifi/dvm/rxon.c
@@ -1378,7 +1378,7 @@ static void iwlagn_chain_noise_reset(struct iwl_priv *priv)
struct iwl_chain_noise_data *data = &priv->chain_noise_data;
int ret;

- if (!(priv->calib_disabled & IWL_CHAIN_NOISE_CALIB_DISABLED))
+ if (priv->calib_disabled & IWL_CHAIN_NOISE_CALIB_DISABLED)
return;

if ((data->state == IWL_CHAIN_NOISE_ALIVE) &&
--
1.8.1.2



2013-05-31 09:11:33

by Berg, Johannes

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: fix chain noise calibration

T24gRnJpLCAyMDEzLTA1LTMxIGF0IDAxOjI5IC0wNDAwLCBOaWtvbGF5IE1hcnR5bm92IHdyb3Rl
Ogo+IEZpcnN0IHN0ZXAgb2YgY2hhaW4gbm9pc2UgY2FsaWJyYXRpb24gcHJvY2VzcyBoYWQgZGlz
YWJsZSBmbGFnIGNoZWNrIGludmVydGVkLgo+IENoYWluIG5vaXNlIGNhbGlicmF0aW9uIG5ldmVy
IHN0YXJ0ZWQgYmVjYXVzZSBvZiB0aGlzLgo+IAo+IFRlc3RlZCBvbiBpbnRlbCA1MzAwIHdpdGgg
dHdvIGFudGVubmFzIGF0dGFjaGVkLiBEcml2ZXIgY29ycmVjdGx5IGRpc2FibGVkIG9uZSBjaGFp
bi4KCkh1aCwgdGhpcyBidWcgbXVzdCBoYXZlIGJlZW4gdGhlcmUgZm9yIGEgbG9uZyB0aW1lIC4u
IHRoYW5rcywgYXBwbGllZCEKCmpvaGFubmVzCgpJbnRlbCBHbWJICkRvcm5hY2hlciBTdHJhc3Nl
IDEKODU2MjIgRmVsZGtpcmNoZW4vTXVlbmNoZW4sIERldXRzY2hsYW5kClNpdHogZGVyIEdlc2Vs
bHNjaGFmdDogRmVsZGtpcmNoZW4gYmVpIE11ZW5jaGVuCkdlc2NoYWVmdHNmdWVocmVyOiBDaHJp
c3RpYW4gTGFtcHJlY2h0ZXIsIEhhbm5lcyBTY2h3YWRlcmVyLCBEb3VnbGFzIEx1c2sKUmVnaXN0
ZXJnZXJpY2h0OiBNdWVuY2hlbiBIUkIgNDc0NTYKVXN0Li1JZE5yLi9WQVQgUmVnaXN0cmF0aW9u
IE5vLjogREUxMjkzODU4OTUKQ2l0aWJhbmsgRnJhbmtmdXJ0IGEuTS4gKEJMWiA1MDIgMTA5IDAw
KSA2MDAxMTkwNTIK