2013-06-03 13:47:52

by John Greene

Subject: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug

Move message to debug mode to reduce log spam under heavy tx (iperf) load.
This message prints in ht debug mode only:
brcms_c_ampdu_dotxstatus_complete: Pkt tx suppressed, illegal channel
possibly 153

Signed-off-by: John Greene <[email protected]>
---
drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
index 1585cc5..bd98285 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
@@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
if (supr_status) {
update_rate = false;
if (supr_status == TX_STATUS_SUPR_BADCH) {
- brcms_err(wlc->hw->d11core,
+ brcms_dbg_ht(wlc->hw->d11core,
"%s: Pkt tx suppressed, illegal channel possibly %d\n",
__func__, CHSPEC_CHANNEL(
wlc->default_bss->chanspec));
--
1.8.1.4

2013-06-03 17:06:38

by Arend van Spriel

Subject: Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug

On 06/03/2013 06:54 PM, Joe Perches wrote:
> On Mon, 2013-06-03 at 09:47 -0400, John Greene wrote:
>> Move message to debug mode to reduce log spam under heavy tx (iperf) load.
> []
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> []
>> @@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
>> if (supr_status) {
>> update_rate = false;
>> if (supr_status == TX_STATUS_SUPR_BADCH) {
>> - brcms_err(wlc->hw->d11core,
>> + brcms_dbg_ht(wlc->hw->d11core,
>> "%s: Pkt tx suppressed, illegal channel possibly %d\n",
>> __func__, CHSPEC_CHANNEL(
>> wlc->default_bss->chanspec));
>
> net_ratelimited instead?

Yes and only when driver debug level is set.

Regards,
Arend

2013-06-03 16:54:46

by Joe Perches

Subject: Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug

On Mon, 2013-06-03 at 09:47 -0400, John Greene wrote:
> Move message to debug mode to reduce log spam under heavy tx (iperf) load.
[]
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
[]
> @@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> if (supr_status) {
> update_rate = false;
> if (supr_status == TX_STATUS_SUPR_BADCH) {
> - brcms_err(wlc->hw->d11core,
> + brcms_dbg_ht(wlc->hw->d11core,
> "%s: Pkt tx suppressed, illegal channel possibly %d\n",
> __func__, CHSPEC_CHANNEL(
> wlc->default_bss->chanspec));

net_ratelimited instead?

2013-06-04 14:10:52

by John Greene

Subject: Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug

On 06/03/2013 01:06 PM, Arend van Spriel wrote:
> On 06/03/2013 06:54 PM, Joe Perches wrote:
>> On Mon, 2013-06-03 at 09:47 -0400, John Greene wrote:
>>> Move message to debug mode to reduce log spam under heavy tx (iperf)
>>> load.
>> []
>>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>>> b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>> []
>>> @@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct
>>> ampdu_info *ampdu, struct scb *scb,
>>> if (supr_status) {
>>> update_rate = false;
>>> if (supr_status == TX_STATUS_SUPR_BADCH) {
>>> - brcms_err(wlc->hw->d11core,
>>> + brcms_dbg_ht(wlc->hw->d11core,
>>> "%s: Pkt tx suppressed, illegal channel
>>> possibly %d\n",
>>> __func__, CHSPEC_CHANNEL(
>>> wlc->default_bss->chanspec));
>>
>> net_ratelimited instead?
>
> Yes and only when driver debug level is set.
>
> Regards,
> Arend
>
>
Thanks for the ACK, Arend. And comments..live and learn.

Certainly they would be reasonable also. Issue (confined to an
annoyance level, hence the workaround) is why this comes up when the
channel being flagged is the same as the one the AP I'm connected with
is on. That is the root of the problem, more work needed on that point
which probably would render this moot.



--
John Greene

2013-06-03 17:08:29

by Arend van Spriel

Subject: Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug

On 06/03/2013 03:47 PM, John Greene wrote:
> Move message to debug mode to reduce log spam under heavy tx (iperf) load.
> This message prints in ht debug mode only:
> brcms_c_ampdu_dotxstatus_complete: Pkt tx suppressed, illegal channel
> possibly 153

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: John Greene <[email protected]>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>