2013-11-14 09:37:24

by Michal Kazior

Subject: [PATCH] ath10k: clear tx status before submitting to mac80211

Garbage was reported in ieee80211_tx_info. This
led to a WARN_ON in cfg80211_calculate_bitrate().

This also fixes some random tx bitrate values
reported through `iw` command.

Reported-By: Kalle Valo <[email protected]>
Signed-off-by: Michal Kazior <[email protected]>
---
drivers/net/wireless/ath/ath10k/txrx.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c
index c511f91..3bc86f1 100644
--- a/drivers/net/wireless/ath/ath10k/txrx.c
+++ b/drivers/net/wireless/ath/ath10k/txrx.c
@@ -75,6 +75,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
ath10k_report_offchan_tx(htt->ar, msdu);

info = IEEE80211_SKB_CB(msdu);
+ memset(info, 0, sizeof(*info));

if (tx_done->discard) {
ieee80211_free_txskb(htt->ar->hw, msdu);
--
1.8.4.rc3

2013-11-15 09:07:08

by Kalle Valo

Subject: Re: [PATCH] ath10k: clear tx status before submitting to mac80211

Michal Kazior <[email protected]> writes:

> Garbage was reported in ieee80211_tx_info. This
> led to a WARN_ON in cfg80211_calculate_bitrate().
>
> This also fixes some random tx bitrate values
> reported through `iw` command.
>
> Reported-By: Kalle Valo <[email protected]>
> Signed-off-by: Michal Kazior <[email protected]>

Thanks, applied.

--
Kalle Valo