2013-11-20 18:14:30

by Karl Beldan

Subject: [PATCH v2] mac80211: use capped prob when computing throughputs

From: Karl Beldan <[email protected]>

Commit 3e8b1eb "mac80211/minstrel_ht: improve rate selection stability"
introduced a local capped prob in minstrel_ht_calc_tp but omitted to use
it to compute the per rate throughput.

Signed-off-by: Karl Beldan <[email protected]>
Cc: Felix Fietkau <[email protected]>
---
net/mac80211/rc80211_minstrel_ht.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index 9702d88..7817a23 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -333,7 +333,7 @@ minstrel_ht_calc_tp(struct minstrel_ht_sta *mi, int group, int rate)
nsecs = 1000 * mi->overhead / MINSTREL_TRUNC(mi->avg_ampdu_len);

nsecs += minstrel_mcs_groups[group].duration[rate];
- tp = 1000000 * ((mr->probability * 1000) / nsecs);
+ tp = 1000000 * ((prob * 1000) / nsecs);

mr->cur_tp = MINSTREL_TRUNC(tp);
}
--
1.8.2

2013-11-25 15:56:30

by Johannes Berg

Subject: Re: [PATCH v2] mac80211: use capped prob when computing throughputs

On Wed, 2013-11-20 at 19:13 +0100, Karl Beldan wrote:
> From: Karl Beldan <[email protected]>
>
> Commit 3e8b1eb "mac80211/minstrel_ht: improve rate selection stability"
> introduced a local capped prob in minstrel_ht_calc_tp but omitted to use
> it to compute the per rate throughput.

Applied.

johannes