2013-12-06 04:07:21

by Larry Finger

[permalink] [raw]
Subject: [PATCH NEXT] rtlwifi: rtl8192c-common: Fix sparse warning

Sparse reports the following:

CHECK drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:570:34: warning: dubious: !x & y

There should be a parens around the expression.

Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Larry Finger <[email protected]>
---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index fd7e4a7..eb78fd8 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -567,7 +567,7 @@ static void rtl92c_dm_dig(struct ieee80211_hw *hw)

if (rtlpriv->dm.dm_initialgain_enable == false)
return;
- if (!rtlpriv->dm.dm_flag & DYNAMIC_FUNC_DIG)
+ if (!(rtlpriv->dm.dm_flag & DYNAMIC_FUNC_DIG))
return;

rtl92c_dm_ctrl_initgain_by_twoport(hw);
--
1.8.4