2014-01-14 06:38:28

by Bartosz Markowski

Subject: [PATCH] ath10k: use VHT phymodes for 20/40MHz channels

chandef does not provide 11n / 11ac split. Use the highest
phymodes for 20/40MHz channels, firmware can operate on.

Signed-off-by: Bartosz Markowski <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 7aa6c4d..e0b1a2a 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -256,10 +256,10 @@ chan_to_phymode(const struct cfg80211_chan_def *chandef)
phymode = MODE_11A;
break;
case NL80211_CHAN_WIDTH_20:
- phymode = MODE_11NA_HT20;
+ phymode = MODE_11AC_VHT20;
break;
case NL80211_CHAN_WIDTH_40:
- phymode = MODE_11NA_HT40;
+ phymode = MODE_11AC_VHT40;
break;
case NL80211_CHAN_WIDTH_80:
phymode = MODE_11AC_VHT80;
--
1.7.9.5

2014-01-17 12:31:32

by Kalle Valo

Subject: Re: [PATCH] ath10k: use VHT phymodes for 20/40MHz channels

Bartosz Markowski <[email protected]> writes:

> chandef does not provide 11n / 11ac split. Use the highest
> phymodes for 20/40MHz channels, firmware can operate on.
>
> Signed-off-by: Bartosz Markowski <[email protected]>

Is this just code cleanup and or does this actually fix something?

> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -256,10 +256,10 @@ chan_to_phymode(const struct cfg80211_chan_def *chandef)
> phymode = MODE_11A;
> break;
> case NL80211_CHAN_WIDTH_20:
> - phymode = MODE_11NA_HT20;
> + phymode = MODE_11AC_VHT20;
> break;
> case NL80211_CHAN_WIDTH_40:
> - phymode = MODE_11NA_HT40;
> + phymode = MODE_11AC_VHT40;
> break;
> case NL80211_CHAN_WIDTH_80:
> phymode = MODE_11AC_VHT80;

But doesn't this mean that we will use, for example, MODE_11AC_VHT20 on
11n mode? I think we need to investigate how MODE_11AC_VHT20 and
MODE_11NA_HT20 actually differ (and the same for 40 MHz channels).

--
Kalle Valo