2014-02-19 21:50:32

by Malcolm Priestley

Subject: [PATCH 1/4] staging: vt6656: s_nsBulkOutIoCompleteWrite reorganise variable order.

Declare in order of pointer use.

Signed-off-by: Malcolm Priestley <[email protected]>
---
drivers/staging/vt6656/usbpipe.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index 79e38b7..16acc9a 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -607,21 +607,14 @@ int PIPEnsSendBulkOut(struct vnt_private *pDevice,

static void s_nsBulkOutIoCompleteWrite(struct urb *urb)
{
- struct vnt_private *pDevice;
+ struct vnt_usb_send_context *pContext =
+ (struct vnt_usb_send_context *)urb->context;
+ struct vnt_private *pDevice = pContext->pDevice;
+ CONTEXT_TYPE ContextType = pContext->Type;
+ unsigned long ulBufLen = pContext->uBufLen;
int status;
- CONTEXT_TYPE ContextType;
- unsigned long ulBufLen;
- struct vnt_usb_send_context *pContext;

DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"---->s_nsBulkOutIoCompleteWrite\n");
- //
- // The context given to IoSetCompletionRoutine is an USB_CONTEXT struct
- //
- pContext = (struct vnt_usb_send_context *)urb->context;
-
- pDevice = pContext->pDevice;
- ContextType = pContext->Type;
- ulBufLen = pContext->uBufLen;

if (!netif_device_present(pDevice->dev))
return;
--
1.9.rc1

2014-02-19 21:56:13

by Joe Perches

Subject: Re: [PATCH 1/4] staging: vt6656: s_nsBulkOutIoCompleteWrite reorganise variable order.

On Wed, 2014-02-19 at 21:50 +0000, Malcolm Priestley wrote:
> Declare in order of pointer use.
[]
> diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
[]
> @@ -607,21 +607,14 @@ int PIPEnsSendBulkOut(struct vnt_private *pDevice,
>
> static void s_nsBulkOutIoCompleteWrite(struct urb *urb)
> {
> - struct vnt_private *pDevice;
> + struct vnt_usb_send_context *pContext =
> + (struct vnt_usb_send_context *)urb->context;

urb->context is a void * so this could be:

struct vnt_usb_send_context *pContext = urb_context;