2014-03-05 12:11:21

by Bartosz Markowski

[permalink] [raw]
Subject: [PATCH v2] ath10k: do not overwrite max_antenna_gain

From: Marek Puzyniak <[email protected]>

Seems like we have an old bug, where we incidently overwrites
the max_antenna_gain we pass to firmware, with zero value.

End of all we are artifically reducing the output power.

This patch removes the excessive assignment on max_antenna_gain,
which is being provided by regulatory domain, and consequently
improves the tx power.

Signed-off-by: Marek Puzyniak <[email protected]>
Signed-off-by: Bartosz Markowski <[email protected]>
---
drivers/net/wireless/ath/ath10k/wmi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 478e7f6..cb1f7b5 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -3393,7 +3393,6 @@ int ath10k_wmi_scan_chan_list(struct ath10k *ar,
ci->max_power = ch->max_power;
ci->reg_power = ch->max_reg_power;
ci->antenna_max = ch->max_antenna_gain;
- ci->antenna_max = 0;

/* mode & flags share storage */
ci->mode = ch->mode;
--
1.7.10



2014-03-07 08:17:44

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2] ath10k: do not overwrite max_antenna_gain

Bartosz Markowski <[email protected]> writes:

> From: Marek Puzyniak <[email protected]>
>
> Seems like we have an old bug, where we incidently overwrites
> the max_antenna_gain we pass to firmware, with zero value.
>
> End of all we are artifically reducing the output power.
>
> This patch removes the excessive assignment on max_antenna_gain,
> which is being provided by regulatory domain, and consequently
> improves the tx power.
>
> Signed-off-by: Marek Puzyniak <[email protected]>
> Signed-off-by: Bartosz Markowski <[email protected]>

Thanks, applied.

--
Kalle Valo