2014-03-16 12:35:10

by Malcolm Priestley

[permalink] [raw]
Subject: [PATCH] staging: vt6656: [BUG] Fix Warning BOGUS urb xfer, pipe 3 != type 1

Stable kernels will need patches
staging: vt6656: s_nsInterruptUsbIoCompleteRead remove usb_fill_bulk_urb
staging: vt6656: PIPEnsInterruptRead use usb_fill_int_urb

and a backported version of this patch.

Signed-off-by: Malcolm Priestley <[email protected]>
---
drivers/staging/vt6656/usbpipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index a4a4bf2..9381654d 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -309,7 +309,7 @@ int PIPEnsInterruptRead(struct vnt_private *priv)

usb_fill_int_urb(priv->pInterruptURB,
priv->usb,
- usb_rcvbulkpipe(priv->usb, 1),
+ usb_rcvintpipe(priv->usb, 1),
priv->int_buf.data_buf,
MAX_INTERRUPT_SIZE,
s_nsInterruptUsbIoCompleteRead,
--
1.9.0



2014-03-17 22:06:20

by Malcolm Priestley

[permalink] [raw]
Subject: Re: [PATCH] staging: vt6656: [BUG] Fix Warning BOGUS urb xfer, pipe 3 != type 1

On 17/03/14 21:50, Greg KH wrote:
> On Sun, Mar 16, 2014 at 12:34:11PM +0000, Malcolm Priestley wrote:
>> Stable kernels will need patches
>> staging: vt6656: s_nsInterruptUsbIoCompleteRead remove usb_fill_bulk_urb
>> staging: vt6656: PIPEnsInterruptRead use usb_fill_int_urb
>>
>> and a backported version of this patch.
>
> So can you send those backported patches to the stable list when this
> patch hits Linus's tree?
Yes will do.


Malcolm

2014-03-17 21:48:07

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: vt6656: [BUG] Fix Warning BOGUS urb xfer, pipe 3 != type 1

On Sun, Mar 16, 2014 at 12:34:11PM +0000, Malcolm Priestley wrote:
> Stable kernels will need patches
> staging: vt6656: s_nsInterruptUsbIoCompleteRead remove usb_fill_bulk_urb
> staging: vt6656: PIPEnsInterruptRead use usb_fill_int_urb
>
> and a backported version of this patch.

So can you send those backported patches to the stable list when this
patch hits Linus's tree?

thanks,

greg k-h