2014-06-02 14:20:30

by Emil Goode

Subject: [PATCH] NFC: st21nfca: Remove double assignment of .owner in struct device_driver

The .owner member of struct device_driver is assigned THIS_MODULE twice.

Introduced by:

commit c44cb2edd01ca31471d9385f0895891b006ab904
("NFC: dts: st21nfca: Add device-tree (Open Firmware) support to st21nfca")

Signed-off-by: Emil Goode <[email protected]>
---
drivers/nfc/st21nfca/i2c.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c
index 3f954ed..95942ca 100644
--- a/drivers/nfc/st21nfca/i2c.c
+++ b/drivers/nfc/st21nfca/i2c.c
@@ -710,7 +710,6 @@ static struct i2c_driver st21nfca_hci_i2c_driver = {
.driver = {
.owner = THIS_MODULE,
.name = ST21NFCA_HCI_I2C_DRIVER_NAME,
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(of_st21nfca_i2c_match),
},
.probe = st21nfca_hci_i2c_probe,
--
1.7.10.4

2014-07-25 09:13:22

by Christophe Ricard

Subject: Re: [PATCH] NFC: st21nfca: Remove double assignment of .owner in struct device_driver

On Mon, 2 Jun 2014 16:21:00 +0200
Emil Goode <[email protected]> wrote:

> The .owner member of struct device_driver is assigned THIS_MODULE
> twice.
>
> Introduced by:
>
> commit c44cb2edd01ca31471d9385f0895891b006ab904
> ("NFC: dts: st21nfca: Add device-tree (Open Firmware) support to
> st21nfca")
>
> Signed-off-by: Emil Goode <[email protected]>
> ---
> drivers/nfc/st21nfca/i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c
> index 3f954ed..95942ca 100644
> --- a/drivers/nfc/st21nfca/i2c.c
> +++ b/drivers/nfc/st21nfca/i2c.c
> @@ -710,7 +710,6 @@ static struct i2c_driver st21nfca_hci_i2c_driver
> = { .driver = {
> .owner = THIS_MODULE,
> .name = ST21NFCA_HCI_I2C_DRIVER_NAME,
> - .owner = THIS_MODULE,
> .of_match_table =
> of_match_ptr(of_st21nfca_i2c_match), },
> .probe = st21nfca_hci_i2c_probe,

Acked-by: Christophe RICARD <[email protected]>