2014-07-12 18:10:42

by Fabian Frédérick

Subject: [PATCH V2 0/9] drivers/net: remove unnecessary break after goto

Small patchset addressing break redundancy on drivers/net branch
(suggested by Joe Perches).

V2: cc to maintainers of each section.


Fabian Frederick (9):
igb: remove unnecessary break after goto
ixgbe: remove unnecessary break after goto
i40e: remove unnecessary break after goto
i40evf: remove unnecessary break after goto
ps3_gelic: remove unnecessary break after goto
orinoco_usb: remove unnecessary break after goto
wcn36xx: remove unnecessary break after goto
rtlwifi: remove unnecessary break after goto
slip: remove unnecessary break after goto

drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 --
drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 --
drivers/net/ethernet/intel/igb/e1000_82575.c | 1 -
drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c | 1 -
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 4 ----
drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 --
drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 3 ---
drivers/net/slip/slhc.c | 1 -
drivers/net/wireless/ath/wcn36xx/main.c | 1 -
drivers/net/wireless/orinoco/orinoco_usb.c | 1 -
drivers/net/wireless/rtlwifi/rtl8192se/fw.c | 1 -
11 files changed, 19 deletions(-)

--
1.9.1

2014-07-12 18:11:46

by Fabian Frédérick

Subject: [PATCH V2 8/9] rtlwifi: remove unnecessary break after goto

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/rtlwifi/rtl8192se/fw.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/fw.c b/drivers/net/wireless/rtlwifi/rtl8192se/fw.c
index 380e7d4..73fa4a1 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192se/fw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/fw.c
@@ -438,7 +438,6 @@ int rtl92s_download_fw(struct ieee80211_hw *hw)
RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
"Unexpected Download step!!\n");
goto fail;
- break;
}

/* <2> Download image file */
--
1.9.1

2014-07-12 18:11:43

by Fabian Frédérick

Subject: [PATCH V2 7/9] wcn36xx: remove unnecessary break after goto

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/ath/wcn36xx/main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index 4ab5370..b71d2b3 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -488,7 +488,6 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
wcn36xx_err("Unsupported key cmd 0x%x\n", cmd);
ret = -EOPNOTSUPP;
goto out;
- break;
}

out:
--
1.9.1

2014-07-12 18:11:42

by Fabian Frédérick

Subject: [PATCH V2 6/9] orinoco_usb: remove unnecessary break after goto

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/orinoco/orinoco_usb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c b/drivers/net/wireless/orinoco/orinoco_usb.c
index c90939c..d3cf7c3 100644
--- a/drivers/net/wireless/orinoco/orinoco_usb.c
+++ b/drivers/net/wireless/orinoco/orinoco_usb.c
@@ -921,7 +921,6 @@ static int ezusb_access_ltv(struct ezusb_priv *upriv,
retval = -EFAULT;
}
goto exit;
- break;
}
if (ctx->in_rid) {
struct ezusb_packet *ans = ctx->buf;
--
1.9.1

2014-07-14 06:46:16

by David Miller

Subject: Re: [PATCH V2 0/9] drivers/net: remove unnecessary break after goto

From: Fabian Frederick <[email protected]>
Date: Sat, 12 Jul 2014 20:09:39 +0200

> Small patchset addressing break redundancy on drivers/net branch
> (suggested by Joe Perches).
>
> V2: cc to maintainers of each section.

Series applied to net-next, thanks.