2014-08-04 00:27:37

by Hans Wennborg

Subject: [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string

Signed-off-by: Hans Wennborg <[email protected]>
---
drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index c159c05..7d6fd59 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr,
else {
ret = il_set_tx_power(il, val, false);
if (ret)
- IL_ERR("failed setting tx power (0x%d).\n", ret);
+ IL_ERR("failed setting tx power (0x%x).\n", ret);
else
ret = count;
}
--
2.0.0.526.g5318336

2014-08-25 20:30:10

by John W. Linville

Subject: Re: [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string

On Sun, Aug 03, 2014 at 05:20:05PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg <[email protected]>
> ---
> drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
> index c159c05..7d6fd59 100644
> --- a/drivers/net/wireless/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c
> @@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr,
> else {
> ret = il_set_tx_power(il, val, false);
> if (ret)
> - IL_ERR("failed setting tx power (0x%d).\n", ret);
> + IL_ERR("failed setting tx power (0x%x).\n", ret);
> else
> ret = count;
> }

It seems like that should be "0x%08x" or similar, no?

--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2014-09-06 03:43:12

by Hans Wennborg

Subject: [PATCH 1/1] iwl4965: fix %d confusingly prefixed with 0x in format string

Signed-off-by: Hans Wennborg <[email protected]>
---
drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 3dcbe2c..cf7996f 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr,
else {
ret = il_set_tx_power(il, val, false);
if (ret)
- IL_ERR("failed setting tx power (0x%d).\n", ret);
+ IL_ERR("failed setting tx power (0x%08x).\n", ret);
else
ret = count;
}
--
2.1.0.rc2.206.gedb03e5