2014-08-28 08:09:28

by Michal Kazior

Subject: [PATCH] ath10k: fix num_legacy_stations tracking

If a station was reassociated, i.e. due to change
of supported rates update via sta_rc_update() the
num_legacy_stations would be (incorrectly) bumped
up leading to unbalanced usage of the var. This in
turn could lock rtscts protection up as enabled.

Signed-off-by: Michal Kazior <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index b858c82..4e30e57 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -1615,7 +1615,7 @@ static int ath10k_station_assoc(struct ath10k *ar, struct ath10k_vif *arvif,
return ret;
}

- if (!sta->wme) {
+ if (!sta->wme && !reassoc) {
arvif->num_legacy_stations++;
ret = ath10k_recalc_rtscts_prot(arvif);
if (ret) {
--
1.8.5.3

2014-09-02 07:18:23

by Kalle Valo

Subject: Re: [PATCH] ath10k: fix num_legacy_stations tracking

Michal Kazior <[email protected]> writes:

> If a station was reassociated, i.e. due to change
> of supported rates update via sta_rc_update() the
> num_legacy_stations would be (incorrectly) bumped
> up leading to unbalanced usage of the var. This in
> turn could lock rtscts protection up as enabled.
>
> Signed-off-by: Michal Kazior <[email protected]>

Thanks, applied.

--
Kalle Valo