2014-09-04 12:52:52

by Matteo Croce

Subject: [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS

ATH10K_DEBUGFS must depend on DEBUG_FS, otherwise
ath10k will generate an invalid pointer on module load

Signed-off-by: Matteo Croce <[email protected]>
---
drivers/net/wireless/ath/ath10k/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig
index 1053bb5..72acb82 100644
--- a/drivers/net/wireless/ath/ath10k/Kconfig
+++ b/drivers/net/wireless/ath/ath10k/Kconfig
@@ -24,7 +24,7 @@ config ATH10K_DEBUG

config ATH10K_DEBUGFS
bool "Atheros ath10k debugfs support"
- depends on ATH10K
+ depends on ATH10K && DEBUG_FS
select RELAY
---help---
Enabled debugfs support
--
2.1.0

2014-09-04 10:04:44

by Kalle Valo

Subject: Re: [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS

Matteo Croce <[email protected]> writes:

> enable ath10k debugfs only when debugfs is enabled,
> fixes an invalid pointer on module insert
>
> --- a/drivers/net/wireless/ath/ath10k/Kconfig
> +++ b/drivers/net/wireless/ath/ath10k/Kconfig

This is missing Signed-off-by, so I cannot take this. Please check
Documentation/SubmittingPatches and please resend.

The safest way to submit a patch is to commit with 'git commit -s' and
then submit the commit with 'git send-email'. But first do a trial run
by submitting it to yourself.

--
Kalle Valo

2014-09-10 11:23:23

by Kalle Valo

Subject: Re: [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS

Matteo Croce <[email protected]> writes:

> ATH10K_DEBUGFS must depend on DEBUG_FS, otherwise
> ath10k will generate an invalid pointer on module load
>
> Signed-off-by: Matteo Croce <[email protected]>

Thanks, applied.

--
Kalle Valo