2014-11-17 07:28:24

by Sujith Manoharan

Subject: [PATCH] ath10k: Block radar events when requested

From: Sujith Manoharan <[email protected]>

This patch ensures that reporting of a radar in simulation
is not done when detection is disabled explicitly by
using the debugfs knob 'dfs_block_radar_events'.

Signed-off-by: Sujith Manoharan <[email protected]>
---
drivers/net/wireless/ath/ath10k/debug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 9147dd3..fa1accd 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -1437,7 +1437,8 @@ static ssize_t ath10k_write_simulate_radar(struct file *file,
{
struct ath10k *ar = file->private_data;

- ieee80211_radar_detected(ar->hw);
+ if (!ar->dfs_block_radar_events)
+ ieee80211_radar_detected(ar->hw);

return count;
}
--
2.1.3

2014-11-17 11:32:34

by Michal Kazior

Subject: Re: [PATCH] ath10k: Block radar events when requested

On 17 November 2014 08:29, Sujith Manoharan <[email protected]> wrote:
> From: Sujith Manoharan <[email protected]>
>
> This patch ensures that reporting of a radar in simulation
> is not done when detection is disabled explicitly by
> using the debugfs knob 'dfs_block_radar_events'.
>
> Signed-off-by: Sujith Manoharan <[email protected]>
> ---
> drivers/net/wireless/ath/ath10k/debug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
> index 9147dd3..fa1accd 100644
> --- a/drivers/net/wireless/ath/ath10k/debug.c
> +++ b/drivers/net/wireless/ath/ath10k/debug.c
> @@ -1437,7 +1437,8 @@ static ssize_t ath10k_write_simulate_radar(struct file *file,
> {
> struct ath10k *ar = file->private_data;
>
> - ieee80211_radar_detected(ar->hw);
> + if (!ar->dfs_block_radar_events)
> + ieee80211_radar_detected(ar->hw);

The simulate_radar knob is meant to be used with
dfs_block_radar_events being true in the first place so you can easily
block real DFS events and inject fake ones for testing of DFS upper
layers with ath10k.

Your patch breaks this. Why would you want to do that?


Michał

2014-11-17 11:52:26

by Sujith Manoharan

Subject: Re: [PATCH] ath10k: Block radar events when requested

Michal Kazior wrote:
> The simulate_radar knob is meant to be used with
> dfs_block_radar_events being true in the first place so you can easily
> block real DFS events and inject fake ones for testing of DFS upper
> layers with ath10k.
>
> Your patch breaks this. Why would you want to do that?

Apparently, this knob is also being used to make sure that
radar detection doesn't happen when NOL is disabled.

I'll check if this test case is needed at all before
adding another knob to the existing pile...

Sujith