2014-11-24 09:39:05

by Vivek Natarajan

Subject: [PATCH 1/2] ath10k: Do not limit RTS threshold value to 2347

Signed-off-by: Vivek Natarajan <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 6 +-----
drivers/net/wireless/ath/ath10k/wmi.h | 1 -
2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 8b60749..61f7e22 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -391,15 +391,11 @@ static int ath10k_mac_set_kickout(struct ath10k_vif *arvif)
return 0;
}

-static int ath10k_mac_set_rts(struct ath10k_vif *arvif, u32 value)
+static int ath10k_mac_set_rts(struct ath10k_vif *arvif, u32 value)
{
struct ath10k *ar = arvif->ar;
u32 vdev_param;

- if (value != 0xFFFFFFFF)
- value = min_t(u32, arvif->ar->hw->wiphy->rts_threshold,
- ATH10K_RTS_MAX);
-
vdev_param = ar->wmi.vdev_param->rts_threshold;
return ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, value);
}
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index a38d788..8a4e779 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -4547,7 +4547,6 @@ struct wmi_dbglog_cfg_cmd {
__le32 config_valid;
} __packed;

-#define ATH10K_RTS_MAX 2347
#define ATH10K_FRAGMT_THRESHOLD_MIN 540
#define ATH10K_FRAGMT_THRESHOLD_MAX 2346

--
1.7.9.5

2014-11-24 10:59:14

by Kalle Valo

Subject: Re: [PATCH 1/2] ath10k: Do not limit RTS threshold value to 2347

Vivek Natarajan <[email protected]> writes:

> Signed-off-by: Vivek Natarajan <[email protected]>

Please no patches with empty commit logs.

Also please send ath10k patches both to ath10k and linux-wireless lists.
This is important especially now that I'm experimenting with patchwork
and it won't see the patch otherwise.

Documentation is here:

http://wireless.kernel.org/en/users/Drivers/ath10k/sources#Submitting_patches

--
Kalle Valo

2014-11-24 11:00:53

by Kalle Valo

Subject: Re: [PATCH 2/2] ath: Fix a false radar detection pattern

Vivek Natarajan <[email protected]> writes:

> For FCC and JP, in one of the radar patterns, PPB and PRF seems to be
> interchanged leading to frequent incorrect radar detections.
>
> Signed-off-by: Vivek Natarajan <[email protected]>
> ---
> drivers/net/wireless/ath/dfs_pattern_detector.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Better to send patches to ath.ko separately from ath10k patches as John
applies ath.ko patches (unless ath10k patches depend on the ath.ko
patches).

--
Kalle Valo

2014-11-24 09:39:39

by Vivek Natarajan

Subject: [PATCH 2/2] ath: Fix a false radar detection pattern

For FCC and JP, in one of the radar patterns, PPB and PRF seems to be
interchanged leading to frequent incorrect radar detections.

Signed-off-by: Vivek Natarajan <[email protected]>
---
drivers/net/wireless/ath/dfs_pattern_detector.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/dfs_pattern_detector.c b/drivers/net/wireless/ath/dfs_pattern_detector.c
index 7a16686..0e383ef 100644
--- a/drivers/net/wireless/ath/dfs_pattern_detector.c
+++ b/drivers/net/wireless/ath/dfs_pattern_detector.c
@@ -86,7 +86,7 @@ static const struct radar_detector_specs fcc_radar_ref_types[] = {
FCC_PATTERN(1, 0, 5, 150, 230, 1, 23),
FCC_PATTERN(2, 6, 10, 200, 500, 1, 16),
FCC_PATTERN(3, 11, 20, 200, 500, 1, 12),
- FCC_PATTERN(4, 50, 100, 1000, 2000, 20, 1),
+ FCC_PATTERN(4, 50, 100, 1000, 2000, 1, 20),
FCC_PATTERN(5, 0, 1, 333, 333, 1, 9),
};

@@ -105,7 +105,7 @@ static const struct radar_detector_specs jp_radar_ref_types[] = {
JP_PATTERN(4, 0, 5, 150, 230, 1, 23),
JP_PATTERN(5, 6, 10, 200, 500, 1, 16),
JP_PATTERN(6, 11, 20, 200, 500, 1, 12),
- JP_PATTERN(7, 50, 100, 1000, 2000, 20, 1),
+ JP_PATTERN(7, 50, 100, 1000, 2000, 1, 20),
JP_PATTERN(5, 0, 1, 333, 333, 1, 9),
};

--
1.7.9.5