2014-12-09 13:20:42

by weiyj_lk

Subject: [PATCH -next] rtlwifi: rtl8192cu: Fix sparse non static symbol warning

From: Wei Yongjun <[email protected]>

Fixes the following sparse warnings:

drivers/net/wireless/rtlwifi/rtl8192cu/hw.c:1595:6: warning:
symbol 'usb_cmd_send_packet' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index 873363ac..5513217 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -1592,7 +1592,7 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
}
}

-bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
+static bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
{
/* Currently nothing happens here.
* Traffic stops after some seconds in WPA2 802.11n mode.

2014-12-09 17:21:03

by Larry Finger

Subject: Re: [PATCH -next] rtlwifi: rtl8192cu: Fix sparse non static symbol warning

On 12/09/2014 07:18 AM, [email protected] wrote:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warnings:

There is only one warning.

>
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c:1595:6: warning:
> symbol 'usb_cmd_send_packet' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>

Changing usb_cmd_send_packet() to be static is correct.

@john: If you want to deal with fixing the commit message, then please add
Acked-by: Larry Finger <[email protected]>

Larry

> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index 873363ac..5513217 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1592,7 +1592,7 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
> }
> }
>
> -bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
> +static bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
> {
> /* Currently nothing happens here.
> * Traffic stops after some seconds in WPA2 802.11n mode.
>
>