2015-01-12 21:15:28

by John W. Linville

Subject: [PATCH] ath10k: document switch case fall-through in __ath10k_scan_finish

Add a comment for indicating that the ATH10K_SCAN_RUNNING case falls
through to the ATH10K_SCAN_ABORTING case in __ath10k_scan_finish. This
will document that the lack of a break is intentional.

Coverity: CID 1260017

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index c4005670cba2..695222e57728 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -2213,6 +2213,7 @@ void __ath10k_scan_finish(struct ath10k *ar)
case ATH10K_SCAN_RUNNING:
if (ar->scan.is_roc)
ieee80211_remain_on_channel_expired(ar->hw);
+ /* fall through */
case ATH10K_SCAN_ABORTING:
if (!ar->scan.is_roc)
ieee80211_scan_completed(ar->hw,
--
2.1.0

2015-01-15 10:36:24

by Kalle Valo

Subject: Re: [PATCH] ath10k: document switch case fall-through in __ath10k_scan_finish

"John W. Linville" <[email protected]> writes:

> Add a comment for indicating that the ATH10K_SCAN_RUNNING case falls
> through to the ATH10K_SCAN_ABORTING case in __ath10k_scan_finish. This
> will document that the lack of a break is intentional.
>
> Coverity: CID 1260017
>
> Signed-off-by: John W. Linville <[email protected]>

Thanks, applied to ath.git.

--
Kalle Valo