2015-01-19 19:45:21

by John W. Linville

Subject: [PATCH] ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb

This clause is conditioned on htc_hdr != NULL, but it will only be NULL
when that check is reached.

Coverity: CID 114318

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/ath/ath9k/htc_hst.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
index a0ff5b637054..d2408da38c1c 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.c
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
@@ -351,11 +351,7 @@ void ath9k_htc_txcompletion_cb(struct htc_target *htc_handle,

return;
ret:
- /* HTC-generated packets are freed here. */
- if (htc_hdr && htc_hdr->endpoint_id != ENDPOINT0)
- dev_kfree_skb_any(skb);
- else
- kfree_skb(skb);
+ kfree_skb(skb);
}

static void ath9k_htc_fw_panic_report(struct htc_target *htc_handle,
--
2.1.0

2015-01-23 19:16:49

by Kalle Valo

Subject: Re: ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb

> This clause is conditioned on htc_hdr != NULL, but it will only be NULL
> when that check is reached.
>
> Coverity: CID 114318
>
> Signed-off-by: John W. Linville <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo